Release/0.28 stable bcn #38
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extract withdrawn state to own field * Patch proposal status labels * Patch references to except_withdrawn * Remove state value from enum * Fix factory field * Fix specs on withdrawn field * Add serializers and Api type fields * Fix failing specs * Apply review recommendations * Fix scope on proposal * Fix last failing spec * Fix upgrade script * Validate files being used * Ensure consistency in method definition * Remove unused partials * Add withdrawn status badge * Fix the migration script * Apply review recommendations * Run linters
* Add initial db structure * Add build method * Add proposal state model + admin presenter * Add proposal_state factory * Add admin interface for proposal states * Misc changes * Fix proposal status * Running linters * Fix failing Specs (decidim#285) * Implement custom answers * Fix proposal fields * Fix the admin status badges * Fix migration script * Add notifiable and anwerable to the proposal states * Deprecating proposals old classes * Migrate frontend classes * Refactor seeds * Fix frontend * Fix more tests * Remove obsolete specs * Running linters * More linting * Fix specs * Fixing the proposals specs * Implement templates * Fixing decidim-templates specs * Remove unused i18n * Fixing more specs * Normalize I18n * reverting helper methods * Add proposal states tests * Run linter * Add release notes * Fix the frontend filters * Lint * Fixing test * Adjust labels * Revert proposal related changes * Fix small issues * Running linters * Update decidim-core/app/cells/decidim/amendable/announcement_cell.rb * Add token validation * Lint * Fix tests * Fix uniquess validator * Refactor commands * fix the specs on refactor * Removed description field * Remove boolean fields * Fix description related errors * Fix some tests * Fix more specs * Fix answerable in proposal answer * Fix migration * Rename migrations * Fix failing specs * Fix failing specs * Fix more specs * Fixing specs * Remove token input * Autogenerate the token * removing default state of not_answered * Remove bangs * Fixing the specs * Fix failing specs ... * Fix the state vs Status * Apply latest changes requested * Normalize locales * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <[email protected]> * Apply suggestions from code review * Running linters, apply latest suggestions * Update index.html.erb * Fix failing specs * Running linters * Running linters * Patch factory * Apply Code Review Recommendations --------- Co-authored-by: Andrés Pereira de Lucena <[email protected]>
* Add valuators multiselect in proposals page to assign multiple valuators in bulk * Implement unassign valuator * Allow valuators assign other valuators to proposal * Restore unrelated changes done by prettier in proposals.js * Fix erblint * Fix specs * Fix more specs * Hide assignment/unassignment panel when no proposals are selected * Revert "Allow valuators assign other valuators to proposal" This reverts commit da11fc3. * Update permissions so valuators can assign other valuators when they are assigned to the same proposal * Fix assign/unassign actions panel UX to only show one at the time * Fix valuator being able to assign/unassign themselves in the proposals list * Update permissions to disallow valuators unassign themselves * Fix and remove specs * Remove spec * Hide Unassign from valuator action to valuators * Fix spec * Update copy * Add tests for multiple assignment / unassignment of evaluators * Update copy key
* Define an admim filters registry and an AdminFilter class to manage filters in admin and use it in proposals * Add test for admin filterable concern using AdminFilter configuration * Add dynamically_translated_filters to admin filters registry * Add some documentation to customize admin filters
* Initial adaptation for using ColorPicker * Patch * Fix Status creation in proposals * Running linters * Fix some specs * Fix javascript preview * Fix the color picker * Fix innerText * Running linters * Fix failing spec * Implement hard-coded colors for states * Bump tailwindcss from 3.3.2 to 3.4.1 * Adapt preview label to background and foreground colors * Implement announcement preview * Add labels with colors in screen readers only * Make the data-label-preview compatible with different targets * Rename data-label-preview to data-css-preview * Sync the change of the foreground color with the background * Separate data-css-preview background and foreground change in their inputs * Fix a11y errors in the page * Fix specs * Use background instead of foreground for the checkboxes shadow * Move the inline styles to an internal CSS definition to define the :checked pseudostate * Add border-color in announcement * Fix stylelint offense * Fix specs * Fix erblint offenses * Use same colors from the class in the migration * Use class defined in the migration to mitigate bugs in the future * Rename method names to match with the keyword arguments * Lower a bit more the boldness of the flash message * Add circle with the accent color in the input shadow * Use ProposalState colors definition instead of hardcoding it * Fix translation for specs * Add specs for live update of labels and announcements * Change usage of 'context' to 'describe' in spec * Extract 'css preview' JavaScript logic to its own file * Extract 'sync radio buttons' JavaScript logic to its own file * Extract 'text copy' JavaScript logic to its own file * Add exceptions to spellchecker --------- Co-authored-by: Andrés Pereira de Lucena <[email protected]>
* Fix proposal state migration * Apply review recomendation
* Fix ProposalStates migration * Lint * Update decidim-proposals/db/migrate/20240110203504_create_default_proposal_states.rb
* Add proposal state label in diff renderer * Apply review recommendations
* Store filters selections in session and allow removing all filters * Implement next and prev links from proposal show * Inspect session * Use with_indifferent_access with session admin_filters * Revert "Inspect session" This reverts commit 495a33b. * Refactor adjacents navigation links * Use spans and adjust margins * Fix wrong spelling * Fix spelling * Ensure the session filtered collection query returns an id * style filters bar * better space handling for containers * Add tests * Change remove all filters text * Remove font-normal class remove all filters tag * Fix expected text in tests * Add comment to adjacent_items method * Move method call to before_action filter * Define index method explicitly in controller * Change translation Co-authored-by: Andrés Pereira de Lucena <[email protected]> * Remove unnecessary method call Co-authored-by: Andrés Pereira de Lucena <[email protected]> --------- Co-authored-by: Hugoren Martinako <[email protected]> Co-authored-by: Andrés Pereira de Lucena <[email protected]> (cherry picked from commit 49bd028)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…a/decidim into release/0.28-stable-bcn
…a/decidim into release/0.28-stable-bcn
) * Add notification to valuators when a proposal is assigned to them. Also adds a new notifications setting to disable this notification * Update decidim-core/spec/commands/decidim/update_notifications_settings_spec.rb Co-authored-by: Eduardo Martínez <[email protected]> --------- Co-authored-by: Eduardo Martínez <[email protected]>
…ecidim#12355" This reverts commit 203fe41.
…a/decidim into release/0.28-stable-bcn
…a/decidim into release/0.28-stable-bcn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT FOR MERGE!
Backports:
Changes: