Connect the seven segment display reloaded usermod to the BH1750_V2 usermod #4503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derqurps is the original author I think. |
|
Hey. What should i do? 😃 |
review this PR please :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Seven Segment Display Reloaded usermod works only with
SN_Photoresistorusermod for maintaining auto brightness.This simply allows using BH1750_V2 to set the brightness instead. The code is nearly the same.
I have tested it, works fine on my setup.
I am not the maintainer of this mod, maybe they can be pinged?
Thanks for this great project.