-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alexa devices invisible/uncontrollable #4214
Fix alexa devices invisible/uncontrollable #4214
Conversation
…ircoookie#3690 and Aircoookie#3685) some users have reported that releases after 0.14.0 are not working reliably. So we add a few "compat" for 8266 that try to reproduce the buildenv of 0.14.0 as much as possible. * platform and platform_packages from 0.14.0 * not using PIO_FRAMEWORK_ARDUINO_MMU_CACHE16_IRAM48 * due to smaller IRAM, we had to move some functions back from IRAM to normal flash (may cause slowdown)
Thank you for this fix. How well tested is it? |
Just tested on Esp32 devboard. When I have time today I check with a wemos mini and remove the unused code then. |
As mentioned, the fix is not from me, but from PakoCosmos |
42fea39
to
f54b817
Compare
Seems like I did bullshit here, sorry for that. |
@Svennte please undo unrelated changes (newlines in platformIO.ini and FX_2Dfcn.ccp). After that, I think we can merge your PR. |
@Svennte I've fixed unrelated changes by maintainer edit. Ready to merge. |
Fix for LED and Scenes uncontrollable using Alexa. Weird behavior regarding to the device names and shared scenes fixed with this. Seen in issue Aircoookie/Espalexa#228 and fixed from @ams-hh Tested by myself and works just fine. Created second pull request here because the library seems to be a bit different from the official Espalexa repo. --------- Co-authored-by: Frank <[email protected]> Co-authored-by: Blaz Kristan <[email protected]>
@softhack007 Thank you, much appreciated! |
Fix for LED and Scenes uncontrollable using Alexa.
Weird behavior regarding to the device names and shared scenes fixed with this.
Seen in issue Aircoookie/Espalexa#228 and fixed from @ams-hh
Tested by myself and works just fine. Created second pull request here because the library seems to be a bit different from the official Espalexa repo.