Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alexa devices invisible/uncontrollable #4214

Merged
merged 10 commits into from
Oct 25, 2024

Conversation

Svennte
Copy link
Contributor

@Svennte Svennte commented Oct 21, 2024

Fix for LED and Scenes uncontrollable using Alexa.
Weird behavior regarding to the device names and shared scenes fixed with this.

Seen in issue Aircoookie/Espalexa#228 and fixed from @ams-hh
Tested by myself and works just fine. Created second pull request here because the library seems to be a bit different from the official Espalexa repo.

softhack007 and others added 6 commits September 4, 2024 23:42
…ircoookie#3690 and Aircoookie#3685)

some users have reported that releases after 0.14.0 are not working reliably. So we add a few "compat" for 8266 that try to reproduce the buildenv of 0.14.0 as much as possible.

* platform and platform_packages from 0.14.0
* not using PIO_FRAMEWORK_ARDUINO_MMU_CACHE16_IRAM48
* due to smaller IRAM, we had to move some functions back from IRAM to normal flash (may cause slowdown)
@Svennte Svennte mentioned this pull request Oct 22, 2024
1 task
@DedeHai
Copy link
Collaborator

DedeHai commented Oct 22, 2024

Thank you for this fix. How well tested is it?
Looks good to me and compiles to the same file sizes.
Just one change request: remove the now unused code.

@Svennte
Copy link
Contributor Author

Svennte commented Oct 22, 2024

Just tested on Esp32 devboard. When I have time today I check with a wemos mini and remove the unused code then.
In the issue I mentioned the people also got it to work with this fix, but I dont now which board they used.

@ams-hh
Copy link

ams-hh commented Oct 22, 2024

As mentioned, the fix is not from me, but from PakoCosmos
https://github.com/vintlabs/fauxmoESP/issues/259#issue-2576866208
I only transplanted it to get a solution for my issue...
And as he mentioned (and me too) it is NOT well tested. Only confirmed working in
the own environment with the own generation of Alexa device.
(I do not use a comercial board. Only naked ESP32S3 on selfmade PCB)

@softhack007 softhack007 added bug rebase needed This PR needs to be re-based to the current development branch labels Oct 22, 2024
@Svennte Svennte force-pushed the fix-alexa-devices-invisible branch 3 times, most recently from 42fea39 to f54b817 Compare October 22, 2024 11:56
@Svennte Svennte changed the base branch from main to 0_15 October 22, 2024 11:58
@Svennte
Copy link
Contributor Author

Svennte commented Oct 22, 2024

Seems like I did bullshit here, sorry for that.
Will look at this this evening.

@softhack007 softhack007 removed the rebase needed This PR needs to be re-based to the current development branch label Oct 25, 2024
@softhack007
Copy link
Collaborator

Seems like I did bullshit here, sorry for that.
Will look at this this evening.

@Svennte please undo unrelated changes (newlines in platformIO.ini and FX_2Dfcn.ccp). After that, I think we can merge your PR.

@softhack007
Copy link
Collaborator

@Svennte I've fixed unrelated changes by maintainer edit. Ready to merge.

@softhack007 softhack007 merged commit 832599b into Aircoookie:0_15 Oct 25, 2024
20 checks passed
softhack007 pushed a commit to MoonModules/WLED that referenced this pull request Oct 25, 2024
Fix for LED and Scenes uncontrollable using Alexa.
Weird behavior regarding to the device names and shared scenes fixed with this.

Seen in issue Aircoookie/Espalexa#228 and fixed from @ams-hh
Tested by myself and works just fine. Created second pull request here because the library seems to be a bit different from the official Espalexa repo.

---------
Co-authored-by: Frank <[email protected]>
Co-authored-by: Blaz Kristan <[email protected]>
@Svennte
Copy link
Contributor Author

Svennte commented Oct 25, 2024

@softhack007 Thank you, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants