Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WLED_AUTOSEGMENTS compile flag #4183

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

PaoloTK
Copy link

@PaoloTK PaoloTK commented Oct 6, 2024

Add flag to enable setting "Make a segment for each output" at compile.

@blazoncek
Copy link
Collaborator

If you don't mind I think WLED_OUTPUT_SEGMENTS or WLED_OUTPUT_AUTOSEGMENTS or WLED_CREATE_AUTOSEGMENTS or perhaps just WLED_AUTOSEGMENTS would be more appropriate.

@PaoloTK
Copy link
Author

PaoloTK commented Oct 7, 2024

If you don't mind I think WLED_OUTPUT_SEGMENTS or WLED_OUTPUT_AUTOSEGMENTS or WLED_CREATE_AUTOSEGMENTS or perhaps just WLED_AUTOSEGMENTS would be more appropriate.

Sure, I like 2nd and 4th the most but your call.

@blazoncek
Copy link
Collaborator

I like the simplicity of the last one too.

@blazoncek blazoncek changed the title Add WLED_AUTOSEGMENT_OUTPUTS compile flag Add WLED_AUTOSEGMENTS compile flag Oct 7, 2024
Copy link
Collaborator

@blazoncek blazoncek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from my side.

@blazoncek blazoncek merged commit c8dafed into Aircoookie:0_15 Oct 9, 2024
20 checks passed
softhack007 added a commit to MoonModules/WLED that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants