Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter for blur amount in the Fire 2012 effect #4078

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

apanteleev
Copy link

With a larger 2D matrix, blur becomes very expensive in terms of performance. On ESP32 with a 32x24 matrix, the Fire 2012 effect with blur runs at 13 FPS, and without blur at about 30 FPS. Sometimes more, but I couldn't figure out why.

This PR adds a user setting for the blur amount so that you can set it to 0 or any other value for aesthetic reasons.

@blazoncek
Copy link
Collaborator

Please rebase for 0_15 branch.

@apanteleev apanteleev changed the base branch from main to 0_15 July 27, 2024 19:50
@apanteleev
Copy link
Author

Rebased.

@blazoncek
Copy link
Collaborator

I will merge this but just out of curiosity, did you check speed with 0_15 branch? There were some optimisations done regarding blur.

@apanteleev
Copy link
Author

did you check speed with 0_15 branch? There were some optimisations done regarding blur.

Not when submitting the PR, but now I did. 29 FPS with blur, 43 FPS without. So, much faster than 0.14 - thanks for letting me know!

@blazoncek blazoncek merged commit 49976ae into Aircoookie:0_15 Jul 29, 2024
18 checks passed
softhack007 pushed a commit to MoonModules/WLED that referenced this pull request Aug 8, 2024
Add a parameter for blur amount in the Fire 2012 effect
softhack007 pushed a commit to MoonModules/WLED that referenced this pull request Aug 9, 2024
Add a parameter for blur amount in the Fire 2012 effect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants