reset usermod TetrisAI back to initial version #3897

muebau · 2024-04-12T20:34:38Z

With this usermod TetrisAI compiles again.

muebau · 2024-04-12T20:38:33Z

blazoncek · 2024-04-13T05:55:14Z

As you are using static variables in your effect function: How does that scale up to playing Tetris on multiple segments?

softhack007 · 2024-04-13T19:56:43Z

So this basicially reverts some of the last commits of the usermod (please correct me if I misunderstood)?

Wouldn't it be smarter to resolve the compiler errors in the code, instead of stripping out things until it compiles?

softhack007

Sorry I cannot approve this PR as it is now.

please avoid using static or global variables in your effect function.
please use strip.now in your effect function
I might have misunderstood - but reverting commits "until it compiles" is usually not a good solution. I would suggest to look at the compiler errors in detail, understand the root cause in the code, and then improve the source code to make the compiler happy.

softhack007 · 2024-04-13T20:07:37Z

usermods/TetrisAI_v2/usermod_v2_tetrisai.h

@@ -96,6 +94,8 @@ void drawGrid(TetrisAIGame* tetris, TetrisAI_data* tetrisai_data)
 ////////////////////////////
 uint16_t mode_2DTetrisAI()
 {
+  static unsigned long lastTime = 0;


Don't use static variables in an effect function.
You can either use SEGENV.aux0, SEGENV.aux1, SEGENV.step, or allocate persistent data by using SEGENV.allocateData(dataSize).

You can find many good examples for this in wled00/FX.cpp

I started to create a 'non blocking' version of the AI part. The commits I took back were related to that.

I need to have a look in the 'static' part.

softhack007 · 2024-04-13T20:08:47Z

usermods/TetrisAI_v2/usermod_v2_tetrisai.h

@@ -116,14 +116,16 @@ uint16_t mode_2DTetrisAI()
  //range 0 - 16
  tetrisai_data->colorInc = SEGMENT.custom2 >> 4;

-  if (!tetrisai_data->tetris || (tetrisai_data->tetris.nLookAhead != nLookAhead
+  static TetrisAIGame tetris(cols < 32 ? cols : 32, rows, 1, piecesData, numPieces);


Please don't use static variables in an effect function (see previous comment).

If you need a permanent and global object, instantiate it in your usermod class and then use a pointer to it within your effect function.
I would recommend against it though, as user may create multiple segments and have them display the same effect. This should not be prohibited.

You ca also keep the TetrisAI_data class unchanged but modify TetrisAIGame class to have a begin() like method which would take parameters as specified in this constructor. You would use begin(cols < 32 ? cols : 32, rows, 1, piecesData, numPieces); within if (SEGENV.call == 0) { ... }condition.

Be mindful though, that segment dimensions may change at any time and cols may not be the same on 100th call of the effect function than it was at 1st.

Well I need to keep the 'internal game grid' between calls. The 'effect' is a real game and has an internal state. How would I make sure

that I provide separate 'game' for every segment (no single static game object possible, I guess)

the segment is not changed to often as every change will reset and reinitialize the game as the game grid needs to change its shape

I am happy to get this feedback, BTW but struggle a bit to provide solutions.

usermods/TetrisAI_v2/usermod_v2_tetrisai.h

blazoncek

I have to agree with @softhack007 and his review comments.

I also tried to provide a hint for better solution than this (which IMO is unacceptable). When you'll be updating the code, please also try to avoid double variables as they are slow compared to float counterparts (ESP32 has HW floating point but only for single precision, not double).

blazoncek · 2024-04-14T18:57:22Z

usermods/TetrisAI_v2/usermod_v2_tetrisai.h

@@ -116,14 +116,16 @@ uint16_t mode_2DTetrisAI()
  //range 0 - 16
  tetrisai_data->colorInc = SEGMENT.custom2 >> 4;

-  if (!tetrisai_data->tetris || (tetrisai_data->tetris.nLookAhead != nLookAhead
+  static TetrisAIGame tetris(cols < 32 ? cols : 32, rows, 1, piecesData, numPieces);


If you need a permanent and global object, instantiate it in your usermod class and then use a pointer to it within your effect function.
I would recommend against it though, as user may create multiple segments and have them display the same effect. This should not be prohibited.

You ca also keep the TetrisAI_data class unchanged but modify TetrisAIGame class to have a begin() like method which would take parameters as specified in this constructor. You would use begin(cols < 32 ? cols : 32, rows, 1, piecesData, numPieces); within if (SEGENV.call == 0) { ... }condition.

Be mindful though, that segment dimensions may change at any time and cols may not be the same on 100th call of the effect function than it was at 1st.

muebau · 2024-04-15T20:46:06Z

OK I need to test if float is good enough for the AI part.

blazoncek · 2024-05-22T06:12:57Z

@muebau is there any interest in bringing this usermod up to speed and adjust code as requested or do we pull the plug and remove it from WLED?
The code that does not compile is of no use and code that does not meet requirements cannot be included.

muebau · 2024-05-22T12:52:27Z

@muebau is there any interest in bringing this usermod up to speed and adjust code as requested or do we pull the plug and remove it from WLED? The code that does not compile is of no use and code that does not meet requirements cannot be included.

Well I will try to find time to fix at least the easy parts ( millis() ).

I am still not sure how to target the problem with the state:
static TetrisAIGame tetris(cols < 32 ? cols : 32, rows, 1, piecesData, numPieces);

I need an instance of TetrisAIGame for each segment, and it needs to be permanent. Every time the size of the segment (or other parameters) changes, I need to destroy the current instance and create a new one to be able to 'work' on the internal game grid.

I would appreciate suggestions from developers with more insight into WLED and C++.

blazoncek · 2024-05-22T18:12:52Z

I need to destroy the current instance and create a new one to be able to 'work' on the internal game grid

Do you really need to destroy it? It is just the two variables that change X and Y.
The other approach might be to just store relevant data in allocateData() buffer and use it as a POD.

Some other effects tackle this so take a look at other 2D effects.

use of strip.now instead of millis() use float instead of double respond to changes in segment size make effect usable with multible segments

muebau · 2024-05-24T07:35:26Z

I think this should fix the issues.
What do you think?

robertvb83 · 2024-05-25T20:55:57Z

Nice update... Tested on my 32x32 Matrix with 4 segments

muebau · 2024-05-25T20:59:46Z

Love to see it is working as it does here. 😂

muebau · 2024-05-25T21:01:04Z

BTW is this a WS2812 4X16X16 setup or something else?

robertvb83 · 2024-05-25T21:05:22Z

BTW is this a WS2812 4X16X16 setup or something else?

Yes exactly this, with an added 3d printed grid and diffuser foil

blazoncek

Apart from a few missing f for float constants this is ok for me.
@softhack007 do you have any objections?

usermods/TetrisAI_v2/usermod_v2_tetrisai.h

…nts to readme

usermods/TetrisAI_v2/gridbw.h

add limitaion information to readme

blazoncek

I would prefer you stick to this repository for completeness.

usermods/TetrisAI_v2/readme.md

reset usermod TetrisAI back to initial version

1bdf387

muebau mentioned this pull request Apr 12, 2024

Usermod TetrisAI compile error #3888

Closed

1 task

blazoncek linked an issue Apr 13, 2024 that may be closed by this pull request

Usermod TetrisAI compile error #3888

Closed

1 task

softhack007 requested changes Apr 13, 2024

View reviewed changes

blazoncek requested changes Apr 14, 2024

View reviewed changes

blazoncek added effect waiting for feedback addition information needed to better understand the issue usermod usermod related labels May 22, 2024

muebau added 2 commits May 23, 2024 16:15

Merge remote-tracking branch 'upstream/0_15' into fix_usermod_tetisai

7808910

fixed static or global variables

5f0c6fc

use of strip.now instead of millis() use float instead of double respond to changes in segment size make effect usable with multible segments

blazoncek approved these changes May 26, 2024

View reviewed changes

usermods/TetrisAI_v2/usermod_v2_tetrisai.h Outdated Show resolved Hide resolved

blazoncek removed the waiting for feedback addition information needed to better understand the issue label May 26, 2024

muebau added 2 commits May 26, 2024 11:01

changed the last double variables and values to float and add more hi…

caf0a5b

…nts to readme

improved readme

69b99ab

softhack007 reviewed May 26, 2024

View reviewed changes

usermods/TetrisAI_v2/gridbw.h Outdated Show resolved Hide resolved

muebau added 2 commits May 26, 2024 21:00

avoid exceptions to stay compatible with ESP8266

97e4eec

add limitaion information to readme

fixed another throw statement

46f6a25

softhack007 approved these changes May 26, 2024

View reviewed changes

center the canvas if the segment exceeds the maximum width or height

abb55f8

blazoncek requested changes May 27, 2024

View reviewed changes

usermods/TetrisAI_v2/readme.md Outdated Show resolved Hide resolved

muebau added 2 commits May 27, 2024 18:15

fixed link to partition table

1bd051d

add more information of the partition table to readme

d5da84d

blazoncek approved these changes May 27, 2024

View reviewed changes

blazoncek merged commit 3a70fb0 into Aircoookie:0_15 May 27, 2024
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

reset usermod TetrisAI back to initial version #3897

reset usermod TetrisAI back to initial version #3897

muebau commented Apr 12, 2024

muebau commented Apr 12, 2024

blazoncek commented Apr 13, 2024

softhack007 commented Apr 13, 2024 •

edited

Loading

softhack007 left a comment

softhack007 Apr 13, 2024

softhack007 Apr 13, 2024

muebau Apr 15, 2024

softhack007 Apr 13, 2024

blazoncek Apr 14, 2024

muebau Apr 15, 2024

blazoncek left a comment

blazoncek Apr 14, 2024

muebau commented Apr 15, 2024

blazoncek commented May 22, 2024

muebau commented May 22, 2024

blazoncek commented May 22, 2024

muebau commented May 24, 2024

robertvb83 commented May 25, 2024

muebau commented May 25, 2024

muebau commented May 25, 2024

robertvb83 commented May 25, 2024

blazoncek left a comment

blazoncek left a comment

reset usermod TetrisAI back to initial version #3897

reset usermod TetrisAI back to initial version #3897

Conversation

muebau commented Apr 12, 2024

muebau commented Apr 12, 2024

blazoncek commented Apr 13, 2024

softhack007 commented Apr 13, 2024 • edited Loading

softhack007 left a comment

Choose a reason for hiding this comment

softhack007 Apr 13, 2024

Choose a reason for hiding this comment

softhack007 Apr 13, 2024

Choose a reason for hiding this comment

muebau Apr 15, 2024

Choose a reason for hiding this comment

softhack007 Apr 13, 2024

Choose a reason for hiding this comment

blazoncek Apr 14, 2024

Choose a reason for hiding this comment

muebau Apr 15, 2024

Choose a reason for hiding this comment

blazoncek left a comment

Choose a reason for hiding this comment

blazoncek Apr 14, 2024

Choose a reason for hiding this comment

muebau commented Apr 15, 2024

blazoncek commented May 22, 2024

muebau commented May 22, 2024

blazoncek commented May 22, 2024

muebau commented May 24, 2024

robertvb83 commented May 25, 2024

muebau commented May 25, 2024

muebau commented May 25, 2024

robertvb83 commented May 25, 2024

blazoncek left a comment

Choose a reason for hiding this comment

blazoncek left a comment

Choose a reason for hiding this comment

softhack007 commented Apr 13, 2024 •

edited

Loading