Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Order Override can not be removed once activated #4300

Closed
1 task done
dosipod opened this issue Nov 21, 2024 · 7 comments · Fixed by #4326
Closed
1 task done

Color Order Override can not be removed once activated #4300

dosipod opened this issue Nov 21, 2024 · 7 comments · Fixed by #4326
Labels
bug confirmed The bug is reproducable and confirmed fixed in source This issue is unsolved in the latest release but fixed in master

Comments

@dosipod
Copy link
Contributor

dosipod commented Nov 21, 2024

What happened?

If you enabled Color Order Override then it would work as expected but if you try to remove that from
/settings/leds page then you no longer can but even worst the page will be populated with so many entries
image
In this example i only added two but things went haywire when I tried to delete it . I am not sure how to solve this without factory reset or editing cfg.json but will do that if nothing to be done from ui

To Reproduce Bug

enabled Color Order Override ,save and exist and then try to remove the Color Order Override

Expected Behavior

enabled /remove works as expected

Install Method

Self-Compiled

What version of WLED?

0.15.0-b7 (build 2410270)

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

I see nothing on serial

Anything else?

Take it easy as we tested that on multiple units

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dosipod dosipod added the bug label Nov 21, 2024
@softhack007 softhack007 added the needs investigation The bug has not yet been reproduced by me. Analysis or more details are needed. label Nov 21, 2024
@dosipod
Copy link
Contributor Author

dosipod commented Nov 21, 2024

Quick work around is set "com":[] in cfg.json so thankfully no reset is needed

@softhack007
Copy link
Collaborator

It would be good to understand the root cause of this problem before releasing 0.15.0-RC1

@blazoncek
Copy link
Collaborator

@dosipod can you provide browser's console log if there are any errors in JS?

@dosipod
Copy link
Contributor Author

dosipod commented Nov 25, 2024

@blazoncek yes there is an error
image

This happened once I added only one and pressed saved ( the number of overrides will go higher if you press save again even if no changes are done to the page )
image

@dosipod
Copy link
Contributor Author

dosipod commented Nov 26, 2024

I just checked other units that do not have color order override and they have the same error so this could be unrelated error

@dosipod
Copy link
Contributor Author

dosipod commented Nov 26, 2024

Just in case something could be spotted ( I could not see any error ) this is the debug log after fresh serial install with only the override set and nothing else changed
s_debug.txt

This is also the cfg.json which shows the "com" entries after the issue

cfg.json

@blazoncek blazoncek added confirmed The bug is reproducable and confirmed and removed needs investigation The bug has not yet been reproduced by me. Analysis or more details are needed. labels Nov 26, 2024
@blazoncek
Copy link
Collaborator

I have the fix ready.

blazoncek added a commit to blazoncek/WLED that referenced this issue Nov 26, 2024
@blazoncek blazoncek mentioned this issue Nov 26, 2024
@blazoncek blazoncek linked a pull request Nov 26, 2024 that will close this issue
netmindz added a commit that referenced this issue Nov 27, 2024
Fix for #4300 - removal of color order override
netmindz pushed a commit that referenced this issue Nov 27, 2024
@softhack007 softhack007 added this to the 0.15.0-final candidate milestone Nov 27, 2024
@softhack007 softhack007 added the fixed in source This issue is unsolved in the latest release but fixed in master label Nov 27, 2024
blazoncek added a commit to blazoncek/WLED that referenced this issue Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed The bug is reproducable and confirmed fixed in source This issue is unsolved in the latest release but fixed in master
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants