-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color Order Override can not be removed once activated #4300
Comments
Quick work around is set "com":[] in cfg.json so thankfully no reset is needed |
It would be good to understand the root cause of this problem before releasing 0.15.0-RC1 |
@dosipod can you provide browser's console log if there are any errors in JS? |
@blazoncek yes there is an error This happened once I added only one and pressed saved ( the number of overrides will go higher if you press save again even if no changes are done to the page ) |
I just checked other units that do not have color order override and they have the same error so this could be unrelated error |
Just in case something could be spotted ( I could not see any error ) this is the debug log after fresh serial install with only the override set and nothing else changed This is also the cfg.json which shows the "com" entries after the issue |
I have the fix ready. |
Fix for #4300 - removal of color order override
What happened?
If you enabled Color Order Override then it would work as expected but if you try to remove that from
/settings/leds page then you no longer can but even worst the page will be populated with so many entries
In this example i only added two but things went haywire when I tried to delete it . I am not sure how to solve this without factory reset or editing cfg.json but will do that if nothing to be done from ui
To Reproduce Bug
enabled Color Order Override ,save and exist and then try to remove the Color Order Override
Expected Behavior
enabled /remove works as expected
Install Method
Self-Compiled
What version of WLED?
0.15.0-b7 (build 2410270)
Which microcontroller/board are you seeing the problem on?
ESP32
Relevant log/trace output
Anything else?
Take it easy as we tested that on multiple units
Code of Conduct
The text was updated successfully, but these errors were encountered: