-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WLED 0.15 seven_segment_display_reloaded crashes ESP32-C3 #4121
Comments
some more info: the esp32-c3 where before working iwth wled 0.14.4 and there i had 3 led outpouts set with ws281x than i updated to 0.15 and i realized that the 3rd led output was missing. and i cant set it again like i mentioned here: now i reflashed 0.15-b4 via https://install.wled.me/ and all settings where reset. the other 3 can be as intended. even when i set up led output 1 and 2 so maybe the 3rd output that went "missing" after updating to 0.15 caused this? but this usermod is still broken since line 244 crashes it |
You will need to contact usermod creator or maintainer as WLED team does not support usermods unless personally involved. |
Hi, im not really a github user. How do i know who created the usermod and how can i contact him? also it is possible like i mentioned that after upgrading from 0.14 to 0.15 and one led output got missing (becausxe of not enough RTM channels like you mentioned on the other thread) that the 3rd led output was still "stored" and cause some problems, which got soloved after all userdata was deleted ? or do you think that was something else? |
Use Git blame feature (available on Github) to find out original author or current maintainer. As for upgrading, backup settings and presets. If anything does not play as you expect, erase all settings and see if reconfiguring helps. If not, there might be a bug (0.15 is still a beta) or the feature has changed. |
ok i think i got it working. and it seems not to be a problem with the usermod, but it could be handled better by the usermode. like i said i had 3 led outputs and when i switched to 0.15 only 2 led outputs are there and the third was missing, like you said bec ause of not enough RTM channels. and so the usermod was using those 10 leds from led output 3 which is missing. so for me it seems to be an array issue.
i removed the 10 leds which i set in the usermod config in the gui and now it seems to work |
i got it woking now and added some checks in the _setLeds function im mostly checking for umSSDRLength . here is the improved code which works now even when i have set some leds that are not present:
|
…ion (solves #4121) I'm not the maintainer of this usermod, but its obvious that the code might overrun array bounds, so fixing this.
@KrX3D I've fixed some potential array bounds violations and pointer errors in the usermod. Please check if it works for you. Important: I'm not the maintainer of this usermod, and I have no idea what the usermod does. I've just applied a bandaid where it seemed reasonable. |
hi, i tested your fix here: for now it seems to work, so thanks for that. i will test it for the next 2-3 days and report back |
Hi, so its not completly solved. But its maybe not only the fault of this usermod. What i did:
than i flashed a completly new esp32 s2 (i tried even others) and when i enable the usermod everything works but when i uncheck at /settings/leds ---> Turn LEDs on after power up/reset: and i restart the esp via gui or unplug the device it doesnt connect again. when i dont enable the usermod and i uncheck it, and restart the device it works. its just this combination that "breaks" it -- EDIT: also after that i cant just flash wled back via visual studio, i need to reflash it via the web installer. |
What happened?
Hello,
i have an ESP32-C3, i just downloaded WLED 0.15 and enabled in the my_config file the usermod:
seven_segment_display_reloaded
with
#define USERMOD_SSDR
after flasing i cant connect to the gui and it seems the esp just hangs. i tried like 3 or 4 other ESP32-C3 and always the same.
when i dont enable the usermod it works.
i got it to "work" by disabling those lines in the usermod_seven_segment_reloaded.h
line 244 and 247:
//umSSDRMask[i] = true;
line 262:
//umSSDRMask[i] = false;
and also line 255:
//strip.setPixelColor(i, 0x000000);
all 4 need to be commented out or i cant connect to the gui
To Reproduce Bug
Expected Behavior
it should work like in 13.3 and 14.4 (was woring before but on a nodemcu)
Install Method
Self-Compiled
What version of WLED?
WLED 0.15.0.-b4 BUILD 2407070
Which microcontroller/board are you seeing the problem on?
ESP32-C3
Relevant log/trace output
No response
Anything else?
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: