forked from felixge/node-sandboxed-module
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can’t:form #1
Open
usernamealreadyis
wants to merge
57
commits into
AidenMontgomery:master
Choose a base branch
from
GistIcon:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Can’t:form #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fork of CoffeeScript support Pull Request (felixge#8)
You need to `require('coffee-script')` before requiring CoffeeScript modules.
It didn't even work, according to the tests.
It is the name of my diety's arch-rival, and a Forbidden Word in my religion.
- Move CoffeeScript to devDependencies. - Remove engines field. - Add bugs, keywords, and license fields.
* For fear that glboal.$$cov... might be present w/o istanbul, I wrapped the istanbul interceptor in a big try catch * To prevent the finding coffeescript.compile and istanbul instrumentSync on every single file, I cache them.
Presumably this will be appropriate for any future built-in source transformers added to the project.
Implements Istanbul coverage support and user-defined sourceTransformers
These days you need to run the .register() function.
Use both the '$$cov_*' and istanbul's default '__coverage__' var to see if istanbul is running
Istanbul, a dev dependency, uses util.deprecate, which doesn't work there.
It was doing element-wise copy, but it should just be assigning the exports.
It is generated via much hackery, but then checked in for a given release, to avoid how this seems way too fragile to do at runtime. Fixes felixge#33. Inspired greatly by @robrich's work in felixge#34.
It'll still work, but the tests fail, and also nobody should be using something that old.
Sources ending with an end-of-line comment (not followed by a newline character) aren't wrapped properly. The second part of the wrapper is treated as part of the comment in such a case. Adding a newline character in fixes this issue.
Also run it on prepublish.
Add docs; clarify tests; use `undefined` to signal default, not falsy.
Since the node.js is now in strict mode we can't get into it with `caller`. However we can use more straightforward hacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can’t automatically merge. Don’t worry, you can still create the pull request.