Deal with sys #28
Merged
Deal with sys #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at #7 again and realized that you pretty much already solved the EventLoop problem by introducing a shared abstract. The only part we have to
#if sysis the concrete implementation, for which we can use a private typedef. This looks like the best pattern here and worked with just a few minor changes.For RacingCondition, I opted to use the stub-approach that EntryPoint also has. It feels slightly silly but does keep the business logic clean. It would be nice to handle these stubs a bit differently, but IMO this is acceptable.
CI is still unhappy about Lock being referenced somewhere which I'll have to investigate.
Edit: I was checking the wrong flag, should be fine now.
Edit: Never mind it's still failing...
Edit: NOW I got it, probably.