Ignore friend request

- Rename FriendRequestResponseValidator to
StoreFriendRequestResponseValidator
- Add destory -ignoring- friend request
- Add TODO refactor code into convention
- Remove extra unneeded comma

app/Http/Controllers/FriendRequestResponseController.php

@@ -5,15 +5,17 @@
 use App\Exceptions\FriendRequestNotFoundException;
 use App\Friend;
 use App\Http\Resources\Friend as FriendResource;
-use App\Validators\FriendRequestResponseValidator;
+use App\Validators\DestroyFriendRequestResponseValidator;
+use App\Validators\StoreFriendRequestResponseValidator;
 use Illuminate\Database\Eloquent\ModelNotFoundException;
+use Illuminate\Http\Response;
 use Illuminate\Support\Arr;
 
 class FriendRequestResponseController extends Controller
 {
     public function store()
     {
-        $data = (new FriendRequestResponseValidator)->validate(request()->all());
+        $data = (new StoreFriendRequestResponseValidator)->validate(request()->all());
         try {
             $friendRequest = Friend::query()
                 ->where('user_id', Arr::get($data, 'user_id'))
@@ -32,4 +34,24 @@ public function store()
 
         return new FriendResource($friendRequest);
     }
+
+    /**
+     * TODO refactor into convention
+     * @return \Illuminate\Http\JsonResponse
+     * @throws FriendRequestNotFoundException
+     */
+    public function destroy()
+    {
+        $data = (new DestroyFriendRequestResponseValidator)->validate(request()->all());
+        try {
+            Friend::query()
+                ->where('user_id', Arr::get($data, 'user_id'))
+                ->where('friend_id', auth()->id())
+                ->firstOrFail()
+                ->delete();
+        } catch (ModelNotFoundException $modelNotFoundException) {
+            throw new FriendRequestNotFoundException;
+        }
+        return response()->json([], Response::HTTP_NO_CONTENT);
+    }
 }

app/Http/Resources/User.php

@@ -28,6 +28,6 @@ public function toArray($request)
             'links' => [
                 'self' => url('/users/' . $this->id)
             ]
-        ];;
+        ];
     }
 }

app/Validators/DestroyFriendRequestResponseValidator.php

@@ -0,0 +1,15 @@
+<?php
+
+namespace App\Validators;
+
+class DestroyFriendRequestResponseValidator
+{
+    public function validate(array $attributes): array
+    {
+        return validator($attributes,
+            [
+                'user_id' => 'required'
+            ]
+        )->validate();
+    }
+}

app/Validators/FriendRequestResponseValidator.php → app/Validators/StoreFriendRequestResponseValidator.php

@@ -2,7 +2,7 @@
 
 namespace App\Validators;
 
-class FriendRequestResponseValidator
+class StoreFriendRequestResponseValidator
 {
     public function validate(array $attributes): array
     {

tests/Feature/FriendsTest.php

@@ -171,7 +171,7 @@ public function a_user_id_and_status_is_required_for_friend_request_response()
         $this->assertArrayHasKey('status', $response->json('errors.meta'));
     }
 
-    /** @test */
+    /** @test */ // TODO refactor into convention
     public function a_friendship_is_retrieved_when_fetching_the_profile()
     {
         $this->withoutExceptionHandling();
@@ -204,7 +204,7 @@ public function a_friendship_is_retrieved_when_fetching_the_profile()
             ]);
     }
 
-    /** @test */
+    /** @test */ // TODO refactor into convention
     public function a_inverse_friendship_is_retrieved_when_fetching_the_profile()
     {
         $this->withoutExceptionHandling();
@@ -236,4 +236,62 @@ public function a_inverse_friendship_is_retrieved_when_fetching_the_profile()
                 ]
             ]);
     }
+
+    /** @test */ // TODO refactor into convention
+    public function friend_request_can_be_ignored()
+    {
+        $this->actingAs($user = factory(User::class)->create(), 'api');
+        $anotherUser = factory(User::class)->create();
+        $this->post('/api/friend-request', [
+            'friend_id' => $anotherUser->id
+        ])->assertOk();
+
+        $response = $this->actingAs($anotherUser, 'api')
+            ->delete('/api/friend-request-response/delete', [
+                'user_id' => $user->id,
+            ])->assertStatus(Response::HTTP_NO_CONTENT);
+
+        $friendRequest = Friend::first();
+        $this->assertNull($friendRequest);
+        $response->assertNoContent();
+    }
+
+    /** @test */ // TODO refactor into convention
+    public function only_the_recipient_can_ignore_a_friend_request()
+    {
+        $this->actingAs($user = factory(User::class)->create(), 'api');
+        $anotherUser = factory(User::class)->create();
+        $this->post('/api/friend-request', [
+            'friend_id' => $anotherUser->id
+        ])->assertOk();
+
+
+        $response = $this->actingAs(factory(User::class)->create(), 'api')
+            ->delete('/api/friend-request-response/delete', [
+                'user_id' => $user->id,
+            ])->assertNotFound();
+
+        $friendRequest = Friend::first();
+        $this->assertNull($friendRequest->confirmed_at);
+        $this->assertNull($friendRequest->status);
+        $response->assertJson([
+            'errors' => [
+                'code' => Response::HTTP_NOT_FOUND,
+                'title' => 'Friend Request Not Found',
+                'detail' => 'Unable to locate the friend request with the given information.'
+            ]
+        ]);
+    }
+
+    /** @test */ // TODO refactor into convention
+    public function a_user_id_is_required_for_ignoring_a_friend_request_response()
+    {
+        $response = $this->actingAs(factory(User::class)->create(), 'api')
+            ->delete('/api/friend-request-response/delete', [
+                'user_id' => '',
+            ]);
+        $response->assertStatus(Response::HTTP_UNPROCESSABLE_ENTITY);
+        $this->assertArrayHasKey('user_id', $response->json('errors.meta'));
+    }
+
 }