Refactor to Post & User Resources

AhmedHelalAhmed · Dec 31, 2021 · 810c3da · 810c3da
1 parent 3475280
commit 810c3da
Show file tree

Hide file tree

Showing 5 changed files with 78 additions and 14 deletions.
diff --git a/app/Http/Controllers/PostController.php b/app/Http/Controllers/PostController.php
@@ -2,7 +2,7 @@
 
 namespace App\Http\Controllers;
 
-use Illuminate\Http\Response;
+use App\Http\Resources\Post as PostResource;
 
 class PostController extends Controller
 {
@@ -15,17 +15,6 @@ public function store()
         ]);
 
         $post = request()->user()->posts()->create($data['data']['attributes']);
-        return response([
-            'data' => [
-                'type' => 'posts',
-                'post_id' => $post->id,
-                'attributes' => [
-                    'body' => $post->body
-                ],
-            ],
-            'links' => [
-                'self' => url('/posts/' . $post->id)
-            ]
-        ], Response::HTTP_CREATED);
+        return new PostResource($post);
     }
 }
diff --git a/app/Http/Resources/Post.php b/app/Http/Resources/Post.php
@@ -0,0 +1,32 @@
+<?php
+
+namespace App\Http\Resources;
+
+use App\Http\Resources\User as UserResource;
+use Illuminate\Http\Resources\Json\JsonResource;
+
+class Post extends JsonResource
+{
+    /**
+     * Transform the resource into an array.
+     *
+     * @param \Illuminate\Http\Request $request
+     * @return array
+     */
+    public function toArray($request)
+    {
+        return [
+            'data' => [
+                'type' => 'posts',
+                'post_id' => $this->id,
+                'attributes' => [
+                    'posted_by' => new UserResource($this->user),
+                    'body' => $this->body
+                ],
+            ],
+            'links' => [
+                'self' => url('/posts/' . $this->id)
+            ]
+        ];
+    }
+}
diff --git a/app/Http/Resources/User.php b/app/Http/Resources/User.php
@@ -0,0 +1,30 @@
+<?php
+
+namespace App\Http\Resources;
+
+use Illuminate\Http\Resources\Json\JsonResource;
+
+class User extends JsonResource
+{
+    /**
+     * Transform the resource into an array.
+     *
+     * @param \Illuminate\Http\Request $request
+     * @return array
+     */
+    public function toArray($request)
+    {
+        return [
+            'data' => [
+                'type' => 'users',
+                'user_id' => $this->id,
+                'attributes' => [
+                    'name' => $this->name
+                ],
+            ],
+            'links' => [
+                'self' => url('/users/' . $this->id)
+            ]
+        ];;
+    }
+}
diff --git a/app/Post.php b/app/Post.php
@@ -7,4 +7,9 @@
 class Post extends Model
 {
     protected $guarded = [];// disable mass assignment
+
+    public function user()
+    {
+        return $this->belongsTo(User::class);
+    }
 }
diff --git a/tests/Feature/PostToTimelineTest.php b/tests/Feature/PostToTimelineTest.php
@@ -42,7 +42,15 @@ public function a_user_can_post_a_text_post()
                     'type' => 'posts',
                     'post_id' => $post->id,
                     'attributes' => [
-                        'body' => $body
+                        'posted_by' => [
+                            'data' => [
+                                'attributes' => [
+                                    'name' => $user->name
+                                ],
+                            ]
+                        ],
+                        'body' => $body,
+
                     ],
                 ],
                 'links' => [