-
Notifications
You must be signed in to change notification settings - Fork 80
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
- Add a new attribute called
loading
to the omnibox which should be "true" or "false" - Inside attributeChangedCallback detect the changing of
loading
and change the content of the submit button to a loading indicator or to the regular indicator based on the state. - Send
did-start-navigation
anddid-navigate
to the UI from window.js - Listen for
did-start-navigation
anddid-navigate
inside the ui scripts - Change the
loading
flag in the omni box totrue
when starting navigation andfalse
when finishing navigation.
Might also want to add a method to stop loading when people click on the loader?
Also, we should consider adding aria roles to mark it as active.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Type
Projects
Status
Backlog