build(deps): update `package.json` to `lerna@8` by michaelfig · Pull Request #11503 · Agoric/agoric-sdk

michaelfig · 2025-06-17T23:17:42Z

closes: #11598

Description

Update our version of Lerna.

Security Considerations

Same considerations as any package version upgrade.

Scaling Considerations

Only used during CI and NPM release process.

Documentation Considerations

n/a

Testing Considerations

n/a

Upgrade Considerations

Maintainer use only.

cloudflare-workers-and-pages · 2025-06-17T23:21:29Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`e5dbd25`
Status:	✅ Deploy successful!
Preview URL:	https://f969aaf7.agoric-sdk.pages.dev
Branch Preview URL:	https://mfig-npm-publish.agoric-sdk.pages.dev

View logs

This version of Lerna is necessary to replace `"workspace:*"` version specifiers with the actual version numbers of the dependencies when `lerna publish` is used. Without this change, the published NPM packages are unusable.

kriskowal · 2025-07-23T15:21:47Z

packages/xsnap/package.json

+    "moddable/modules/data/**",
+    "moddable/xs/includes/**",
+    "moddable/xs/makefiles/**",
+    "moddable/xs/sources/**",


Interesting. This is apropos of Lerna? Npm pack was forgiving.

Yeah, when testing the viability of the packages, I noticed the missing files from these subtrees. I think this was fixed a few times by other PRs that never merged.

I think we had some tool / script somewhere allowing us to check if there were any differences in files included in an npm package. I'm really curious why this would now have changed.

kriskowal · 2025-07-23T15:23:20Z

packages/xsnap/test/install.test.js

-  const { stdout: npmout } = await $`npm pack --json`;
-  const [{ filename }] = JSON.parse(npmout);
+  const filename = join(tmp, 'package.tgz');
+  await $`yarn pack --out ${filename}`;


Ah, because yarn will account for the workspace protocol and npm will not. Thanks. Also nice that we can specify and don’t have to parse out the filename.

mergify · 2025-07-23T16:15:38Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #11648.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Looks like `lint-primary` is suffering from timeouts, probably due to excessive work being done by `tsc`.

mergify · 2025-07-23T18:43:46Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #11650.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

kriskowal · 2025-07-23T22:39:50Z

@Mergifyio requeue

mergify · 2025-07-23T22:39:53Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify · 2025-07-23T22:40:57Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #11652.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mhofman

I have verified that the newly published dev versions correctly rewrite the workspace: dependencies.

mhofman · 2025-07-24T01:19:06Z

packages/xsnap/package.json

+    "moddable/modules/data/**",
+    "moddable/xs/includes/**",
+    "moddable/xs/makefiles/**",
+    "moddable/xs/sources/**",


I think we had some tool / script somewhere allowing us to check if there were any differences in files included in an npm package. I'm really curious why this would now have changed.

mhofman · 2025-07-24T01:33:20Z

.yarn/patches/@lerna-conventional-commits-npm-5.6.2-a373ba4bc0.patch

What is the behavior of the new lerna regarding pre-releases? We are using pre-releases tags currently both for dev packages and for our "release" versions.

We do have a test that verifies that npm pack works. That test switched to using yarn pack in this change, which probably accounts for the difference in requirements. Presumably, lerna drives yarn pack.

I don't think what pack command we uses changes anything to my question, which was specifically how lerna generated the new version depending on whether it was a pre-release or not. Seeing #11655, in lerna 8, the semantics of bumping version for 0.x were dependent on whether it was a pre-release or not, which seems misguided.

refs: #11503, #11664 ## Description Solve abysmal [perf issues on macOS (#11664)](#11664) found in `lerna-8` by using `@lerna-lite` instead. Also, apply the patch as described in [comments](https://github.com/Agoric/agoric-sdk/pull/11503/files#r2227087619) after the [lerna-8 upgrade PR #11503](#11503) landed. ### Security Considerations CI and release management only. ### Scaling Considerations n/a ### Documentation Considerations n/a ### Testing Considerations CI ### Upgrade Considerations Relying on a more maintained package.

michaelfig assigned mujahidkay Jun 17, 2025

michaelfig force-pushed the mfig-npm-publish branch 2 times, most recently from 77e6d25 to 3876437 Compare June 18, 2025 19:02

This was referenced Jul 14, 2025

NPM packages broken since adopting workspace protocol #11598

Closed

ci(after-merge): fix NPM publishing #11599

Closed

michaelfig added 6 commits July 22, 2025 13:06

build(deps): update package.json to lerna@8

e89ffe8

This version of Lerna is necessary to replace `"workspace:*"` version specifiers with the actual version numbers of the dependencies when `lerna publish` is used. Without this change, the published NPM packages are unusable.

ci(after-merge): fail dev-canary on publish error

f02303a

chore(client-utils): fix scripts.prepack

0708d81

fix(pack): use yarn for packing "workspace:*" dep versions

59f4b7e

build(deps): use "workspace:*" versions when possible

3a7318b

build(deps): regenerate yarn.lock

fd6131f

michaelfig force-pushed the mfig-npm-publish branch from 3876437 to fd6131f Compare July 22, 2025 19:20

michaelfig added tooling repo-wide infrastructure hygiene Tidying up around the house force:integration Force integration tests to run on PR labels Jul 22, 2025

chore(fast-usdc): add missing types

461b050

kriskowal mentioned this pull request Jul 23, 2025

chore: Sync Endo versions 2025-07-22 Agoric/documentation#1281

Merged

michaelfig marked this pull request as ready for review July 23, 2025 02:26

michaelfig requested a review from a team as a code owner July 23, 2025 02:26

michaelfig requested a review from AgoricTriage July 23, 2025 02:26

kriskowal approved these changes Jul 23, 2025

View reviewed changes

michaelfig added the automerge:no-update (expert!) Automatically merge without updates label Jul 23, 2025

mergify bot added a commit that referenced this pull request Jul 23, 2025

Merge of #11503

c37dcf6

mergify bot mentioned this pull request Jul 23, 2025

merge queue: embarking master (d1c16b2) and #11503 together #11648

Closed

michaelfig removed the force:integration Force integration tests to run on PR label Jul 23, 2025

ci(lint-primary): increase timeout

e5dbd25

Looks like `lint-primary` is suffering from timeouts, probably due to excessive work being done by `tsc`.

michaelfig force-pushed the mfig-npm-publish branch from 31338d3 to e5dbd25 Compare July 23, 2025 16:26

mergify bot added a commit that referenced this pull request Jul 23, 2025

Merge of #11503

9254163

mergify bot mentioned this pull request Jul 23, 2025

merge queue: embarking master (d1c16b2) and #11503 together #11650

Closed

mergify bot added a commit that referenced this pull request Jul 23, 2025

Merge of #11503

f958e75

mergify bot mentioned this pull request Jul 23, 2025

merge queue: embarking master (d1c16b2) and #11503 together #11652

Closed

michaelfig merged commit 25728ab into master Jul 23, 2025
121 of 136 checks passed

michaelfig deleted the mfig-npm-publish branch July 23, 2025 22:44

turadg mentioned this pull request Jul 24, 2025

update Lerna to v7 #8062

Closed

mhofman reviewed Jul 24, 2025

View reviewed changes

michaelfig mentioned this pull request Jul 24, 2025

chore(deps): use @lerna-lite instead #11655

Merged

mhofman mentioned this pull request Sep 8, 2025

pack and install xsnap test fails on version bumps #11896

Open

Conversation

michaelfig commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

Uh oh!

cloudflare-workers-and-pages bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying agoric-sdk with Cloudflare Pages

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Jul 23, 2025

Uh oh!

mergify bot commented Jul 23, 2025

Uh oh!

kriskowal commented Jul 23, 2025

Uh oh!

mergify bot commented Jul 23, 2025

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Uh oh!

mergify bot commented Jul 23, 2025

Uh oh!

Uh oh!

mhofman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kriskowal Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

michaelfig commented Jun 17, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jun 17, 2025 •

edited

Loading

kriskowal Jul 29, 2025 •

edited

Loading