Replace phantomjs for headless testing #3806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2022
mattlindsey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove phantomjs from cucumber and rspec tests and replace with the cuprite gem using headless chrome. I tried first using selenium (rather than cuprite), but that seemed to have many more issues.
Some tests were commented out due errors in cuprite, but can be added back later if deemed useful. I also commented out Bootstrap tooltips due to errors in cuprite, but these could be added back for non-test environments with a conditional statement, if desired.
Note that jasmine still uses phantomjs but can be upgraded (issue 3804) to use chrome also.
fixes #3805