Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of MATERIALIZED|ALIAS expr for the column def #86

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Add support of MATERIALIZED|ALIAS expr for the column def #86

merged 1 commit into from
Jul 22, 2024

Conversation

git-hulk
Copy link
Member

This closes #85

@git-hulk git-hulk force-pushed the feature/column-def-alias-materialized branch from eaf39a1 to 10574e7 Compare July 22, 2024 07:48
@git-hulk git-hulk requested a review from Lance726 July 22, 2024 07:49
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10036793304

Details

  • 30 of 34 (88.24%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 58.316%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/ast.go 17 21 80.95%
Totals Coverage Status
Change from base Build 9976591247: 0.04%
Covered Lines: 5943
Relevant Lines: 10191
💛 - Coveralls

Lance726
Lance726 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@Lance726 Lance726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk git-hulk merged commit f6b95a0 into AfterShip:master Jul 22, 2024
1 check passed
git-hulk added a commit to git-hulk/clickhouse-sql-parser that referenced this pull request Nov 29, 2024
@git-hulk
Add support of MATERIALIZED|ALIAS expr for the column def (AfterShip#86)
f618364
@git-hulk git-hulk deleted the feature/column-def-alias-materialized branch November 29, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lance726 Lance726 Lance726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support MATERIALIZED columns in table create statement
3 participants
@git-hulk @coveralls @Lance726