Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing type level in codec constraint while generating SQL #82

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Fix missing type level in codec constraint while generating SQL #82

merged 1 commit into from
Jul 16, 2024

Conversation

laojianzi
Copy link
Contributor

No description provided.

@git-hulk git-hulk changed the title feat: save level for codec delta Fix missing type level in codec constraint while generating SQL Jul 16, 2024
@git-hulk git-hulk merged commit ec42872 into AfterShip:master Jul 16, 2024
1 check passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9953816476

Details

  • 12 of 16 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 58.084%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/ast.go 8 12 66.67%
Totals Coverage Status
Change from base Build 9949491275: 0.02%
Covered Lines: 5906
Relevant Lines: 10168
💛 - Coveralls

@laojianzi laojianzi deleted the codec-delta-level branch July 16, 2024 09:18
git-hulk pushed a commit to git-hulk/clickhouse-sql-parser that referenced this pull request Nov 29, 2024
@laojianzi @git-hulk
Fix missing type level in codec constraint (AfterShip#82)
bfc8e6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laojianzi @coveralls @git-hulk