Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "=" operator should be present if the setting variable carries a value #80

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

laojianzi
Copy link
Contributor

@laojianzi laojianzi commented Jul 16, 2024

ref: https://clickhouse.com/docs/en/sql-reference/statements/alter/role

This syntax may be an error

ALTER ROLE r3_01293 SETTINGS max_memory_usage 5000000;

@laojianzi laojianzi force-pushed the alter-role-settings branch from 74b4772 to f04e0b4 Compare July 16, 2024 09:00
@coveralls
Copy link

coveralls commented Jul 16, 2024

Pull Request Test Coverage Report for Build 9954530352

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 12 of 20 (60.0%) changed or added relevant lines in 4 files are covered.
  • 1383 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.2%) to 58.276%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_column.go 1 2 50.0%
parser/parse_system.go 8 10 80.0%
parser/ast.go 1 6 16.67%
Files with Coverage Reduction New Missed Lines %
parser/parser_column.go 20 61.01%
parser/parser_query.go 28 61.91%
parser/parser_alter.go 79 72.27%
parser/ast.go 1256 54.11%
Totals Coverage Status
Change from base Build 9949491275: 0.2%
Covered Lines: 5950
Relevant Lines: 10210

💛 - Coveralls

Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@git-hulk git-hulk changed the title fix: when alter role settings, an equal sign operator should be present if the variable carries a value Fix the "=" operator should be present if the setting variable carries a value Jul 16, 2024
@git-hulk git-hulk merged commit 11f26f8 into AfterShip:master Jul 16, 2024
1 check passed
git-hulk pushed a commit to git-hulk/clickhouse-sql-parser that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants