Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling Delta with number literal #78

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Handling Delta with number literal #78

merged 3 commits into from
Jul 16, 2024

Conversation

sharadgaur
Copy link
Contributor

Issue #77

@coveralls
Copy link

coveralls commented Jul 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9947874004

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 58.066%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_column.go 2 4 50.0%
Totals Coverage Status
Change from base Build 9940421425: 0.02%
Covered Lines: 5896
Relevant Lines: 10154
💛 - Coveralls

@sharadgaur
Removing comment
f58163b 
Signed-off-by: Sharad Gaur <[email protected]>
git-hulk
git-hulk approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk git-hulk merged commit f770c15 into AfterShip:master Jul 16, 2024
1 check passed
@git-hulk
Copy link
Member

@sharadgaur Thanks for your contribution!

git-hulk pushed a commit to git-hulk/clickhouse-sql-parser that referenced this pull request Nov 29, 2024
@sharadgaur @git-hulk
Handling Delta with number literal (AfterShip#78)
deb8951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharadgaur @coveralls @git-hulk