Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add Format SQL correctness check and fix failed tests #76

Merged
merged 1 commit into from
Jul 15, 2024
Merged

test: Add Format SQL correctness check and fix failed tests #76

merged 1 commit into from
Jul 15, 2024

Conversation

laojianzi
Copy link
Contributor

@laojianzi laojianzi commented Jul 15, 2024 •
edited
Loading

Re-parsing testdata's Format SQL for correctness

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9939736055

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 58.049%
Totals Coverage Status
Change from base Build 9938124097: -0.02%
Covered Lines: 5892
Relevant Lines: 10150
💛 - Coveralls

git-hulk
git-hulk approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@git-hulk git-hulk merged commit 5c4ca69 into AfterShip:master Jul 15, 2024
1 check passed
git-hulk pushed a commit to git-hulk/clickhouse-sql-parser that referenced this pull request Nov 29, 2024
@laojianzi @git-hulk
Fix wrongly format the ON CLUSTER and LIMIT OFFSET clause (AfterShip#76)
2153584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laojianzi @coveralls @git-hulk