Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cannot parse multi JOIN expressions #56

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Mar 4, 2024

This closes #55

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8140062777

Details

  • 93 of 122 (76.23%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 57.118%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/ast_visitor.go 3 5 60.0%
parser/ast.go 41 53 77.36%
parser/parser_query.go 49 64 76.56%
Files with Coverage Reduction New Missed Lines %
parser/parser_query.go 2 60.87%
Totals Coverage Status
Change from base Build 8074699257: 0.2%
Covered Lines: 5541
Relevant Lines: 9701

💛 - Coveralls

@git-hulk git-hulk requested a review from Lance726 March 4, 2024 12:26
@git-hulk git-hulk merged commit 6fcbda2 into AfterShip:master Mar 5, 2024
1 check passed
@git-hulk git-hulk deleted the fix/multi-join branch November 29, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Syntax Compatibility] Parsing fails when there are multiple joins in the statement
3 participants