Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix should regard double quote string as an ident #54

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Feb 28, 2024

This closes #53

ClickHouse should always regard the double quote string as an ident, which behaves differently with MySQL or other widely used databases.

also refer: https://clickhouse.com/docs/en/sql-reference/syntax#keywords

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8074568443

Details

  • -2 of 41 (95.12%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 56.908%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_table.go 10 12 83.33%
Totals Coverage Status
Change from base Build 8062675458: 0.009%
Covered Lines: 5478
Relevant Lines: 9626

💛 - Coveralls

@git-hulk git-hulk requested a review from Lance726 February 28, 2024 02:53
@git-hulk git-hulk merged commit 16a015a into AfterShip:master Feb 28, 2024
1 check passed
@git-hulk git-hulk deleted the fix/double-quote-as-ident branch November 29, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Syntax Compatibility] Identifiers with quotes serialized output the wrong content
3 participants