Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement visitor for AST #45

Merged
merged 11 commits into from
Feb 10, 2024
Merged

Implement visitor for AST #45

merged 11 commits into from
Feb 10, 2024

Conversation

zfy0701
Copy link
Contributor

@zfy0701 zfy0701 commented Feb 9, 2024 •
edited
Loading

resolve #8

@zfy0701 zfy0701 marked this pull request as ready for review February 9, 2024 07:44
@zfy0701
Copy link
Contributor Author

zfy0701 commented Feb 9, 2024

there are several ways to implement visitor pattern, this is my preference but I'm happy to implement this as your team feels right

@git-hulk
Copy link
Member

git-hulk commented Feb 9, 2024

@zfy0701 Thanks for your great contribution.

The current visitor pattern looks good to me. I will take another pass before merging.

@coveralls
Copy link

coveralls commented Feb 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7852720313

  • -1188 of 2242 (47.01%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.8%) to 56.416%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/ast_visitor.go 314 712 44.1%
parser/ast.go 740 1530 48.37%
Totals Coverage Status
Change from base Build 7794018411: -2.8%
Covered Lines: 5430
Relevant Lines: 9625
💛 - Coveralls

@git-hulk git-hulk changed the title implement visitor for ast Implement visitor for AST Feb 9, 2024
git-hulk
git-hulk previously approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk git-hulk requested a review from Lance726 February 9, 2024 16:17
Lance726
Lance726 reviewed Feb 10, 2024
View reviewed changes
Copy link
Collaborator

@Lance726 Lance726 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments, the rest of LGTM.

@zfy0701
Copy link
Contributor Author

zfy0701 commented Feb 10, 2024

done

@Lance726 Lance726 requested a review from git-hulk February 10, 2024 04:57
@git-hulk git-hulk merged commit dc1094e into AfterShip:master Feb 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@Lance726 Lance726 Lance726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement AST walker
4 participants
@zfy0701 @git-hulk @coveralls @Lance726