Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cannot parse LEFT JOIN correctly #41

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Fix cannot parse LEFT JOIN correctly #41

merged 3 commits into from
Feb 5, 2024

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Feb 5, 2024

This closes #40

@git-hulk git-hulk requested a review from Lance726 February 5, 2024 08:32
@coveralls
Copy link

coveralls commented Feb 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7781798018

  • -9 of 34 (73.53%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 59.198%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_query.go 20 29 68.97%
Files with Coverage Reduction New Missed Lines %
parser/parser_query.go 1 60.6%
Totals Coverage Status
Change from base Build 7780693192: 0.3%
Covered Lines: 4367
Relevant Lines: 7377
💛 - Coveralls

Lance726
Lance726 reviewed Feb 5, 2024
View reviewed changes
git-hulk
git-hulk commented Feb 5, 2024
View reviewed changes
Lance726
Lance726 reviewed Feb 5, 2024
View reviewed changes
@git-hulk git-hulk merged commit 258ea28 into AfterShip:master Feb 5, 2024
1 check passed
@git-hulk git-hulk deleted the select-with-left-join branch November 29, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lance726 Lance726 Lance726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot parse the LEFT JOIN expression
3 participants
@git-hulk @coveralls @Lance726