Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FINAL processing to SELECT and fixed conversion of selectExpr to string #34

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

Dolso
Copy link
Contributor

@Dolso Dolso commented Jan 29, 2024

Hi!

While using -format I encountered an unexpected behavior

You can see it:
SELECT * FROM clickhouse FINAL;
SELECT * FROM clickhouse LIMIT 100;

Thank you in advance!

fixed conversion of selectExpr to string, limit was not taken into account
@git-hulk
Copy link
Member

git-hulk commented Jan 30, 2024

Hi @Dolso, thanks for your contribution.

Would you mind running make update_test on your side to update the test data?

@git-hulk git-hulk self-requested a review January 30, 2024 04:00
@Dolso
Copy link
Contributor Author

Dolso commented Jan 30, 2024

Would you mind running make update_test on your side to update the test data?

I did it

@git-hulk
Copy link
Member

@Dolso Thank you!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7707214113

  • -9 of 17 (47.06%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 58.896%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_query.go 6 10 60.0%
parser/ast.go 2 7 28.57%
Totals Coverage Status
Change from base Build 7498464439: -0.03%
Covered Lines: 4330
Relevant Lines: 7352

💛 - Coveralls

@git-hulk git-hulk merged commit 9ef9ef7 into AfterShip:master Jan 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants