Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the literal string by replacing with the const variable #116

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Remove the literal string by replacing with the const variable #116

merged 2 commits into from
Dec 30, 2024

Conversation

git-hulk
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Dec 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12533673650

Details

  • 111 of 122 (90.98%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 60.347%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_column.go 53 55 96.36%
parser/parser_table.go 26 29 89.66%
parser/parser_query.go 18 24 75.0%
Totals Coverage Status
Change from base Build 12514927594: -0.004%
Covered Lines: 6392
Relevant Lines: 10592
💛 - Coveralls

@git-hulk git-hulk requested a review from Lance726 December 29, 2024 08:00
@git-hulk git-hulk merged commit 392b4ce into AfterShip:master Dec 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lance726 Lance726 Lance726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@git-hulk @coveralls @Lance726