add shell scripts in mno analysis tools dir #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMwendwa
force-pushed
the
mno-shell-scripts
branch
from
ea0ab92 to
bce2e1b
Compare
…ame as an optional parameter
IsaackMwenda
requested changes
Jun 11, 2020
There was a problem hiding this comment.
This looks good only requesting changes so that I can take a final look at the memory profile implementation. See an example here: https://github.com/AfricasVoices/Project-IMAQAL-COVID19/blob/5a7784597645fdd919b0e5aa0ed8d421ffde7ca8/docker-run-generate-outputs.sh#L61
mno_analysis_tools/docker-run-compute-msg-difference-btwn-two-firebase-time-periods.sh
Outdated
Show resolved
Hide resolved
mno_analysis_tools/docker-run-compute-msg-difference-btwn-two-firebase-time-periods.sh
Outdated
Show resolved
Hide resolved
DanielMwendwa
force-pushed
the
mno-shell-scripts
branch
from
206b97c to
53cb3ac
Compare
IsaackMwenda
approved these changes
Jun 16, 2020
I'll open another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
review #92 first