Add function for interrupting URNs #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows bulk removal of contacts from flows. Also updates the send_message_to_urn function to optionally interrupt before sending a message. Tested against our Experimental instance.
lukechurch
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Thanks @as2388 - that's easier to use from my side than I had expected :)
One minor comments about the doc-comment initialy confusing me
rapid_pro_tools/rapid_pro_client.py
Outdated
| """ | ||
| Interrupts the given URNs from the flows they are currently in, if any. | ||
|
|
||
| Makes 1 request for every 100 URNs. |
There was a problem hiding this comment.
I misunderstood this comment on first read to say that it was going to buffer requests and so wouldn't do anything until it had received 100 URNs.
There was a problem hiding this comment.
Changed to "If the list of URNs contains more than 100 items, requests will be made in batches of 100 URNs at a time."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows bulk removal of contacts from flows. Also updates the send_message_to_urn function to optionally interrupt before sending a message.
Tested against our Experimental instance.