-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Msg Difference Per Period #73
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…periods (the time period for firebase is a constant number)
8f31a9d
to
97341ee
Compare
… message difference between two firebase time periods'
IsaackMwenda
requested changes
Mar 5, 2020
Co-Authored-By: Isaack Mwenda <[email protected]>
…target_message_direction} message direction' Co-Authored-By: Isaack Mwenda <[email protected]>
Co-Authored-By: Isaack Mwenda <[email protected]>
…nce_per_two_firebase_period_output_file_path
…od with is constant
' script to 'compute_msg_difference_btwn_two_firebase_time_periods.py'
This script has been renamed
IsaackMwenda
approved these changes
Mar 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Daniel lets test this over a subset test dataset before merging
mno_analysis_tools/compute_msg_difference_btwn_two_firebase_time_periods.py
Outdated
Show resolved
Hide resolved
mno_analysis_tools/compute_msg_difference_btwn_two_firebase_time_periods.py
Outdated
Show resolved
Hide resolved
mno_analysis_tools/compute_msg_difference_btwn_two_firebase_time_periods.py
Outdated
Show resolved
Hide resolved
mno_analysis_tools/compute_msg_difference_btwn_two_firebase_time_periods.py
Outdated
Show resolved
Hide resolved
…case & update time period to firebase time period Co-Authored-By: Isaack Mwenda <[email protected]>
…_period Co-Authored-By: Isaack Mwenda <[email protected]>
Co-Authored-By: Isaack Mwenda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…periods (the time period for firebase is a constant number)