script to compute number messages in a given period of time #67

DanielMwendwa · 2020-02-14T19:30:18Z

No description provided.

as2388

Waiting for #65 due to the common logic.

mno_analysis_tools/compute_messages_per_period.py

Co-Authored-By: Alexander Simpson <[email protected]>

…d direction of msg

mno_analysis_tools/Pipfile.lock

mno_analysis_tools/compute_messages_per_period.py

remove extra space after comma Co-Authored-By: Alexander Simpson <[email protected]>

renamed variable Co-Authored-By: Alexander Simpson <[email protected]>

as2388

Thanks. Could you request review from Isaack next?

mno_analysis_tools/compute_messages_per_period.py

remove comma from string Co-Authored-By: Alexander Simpson <[email protected]>

DanielMwendwa · 2020-02-28T13:23:02Z

Thanks. Could you request review from Isaack next?

Yes

…y validate later

mno_analysis_tools/compute_messages_per_period.py

IsaackMwenda · 2020-03-02T11:15:27Z

mno_analysis_tools/compute_messages_per_period.py

+    message_difference_per_period = []
+    for index in range(len(messages_per_period) - 1):
+        next_index = index + 1
+        message_difference_per_period.append({


As discussed offline let move this to a different script as the time period for this is a constant firebase period i.e 10 seconds whereas the time period for messages_per_period maybe 1 day/ 1 week etc.. (cc @as2388).

Rename parser help message Co-Authored-By: Isaack Mwenda <[email protected]>

Updated log information Co-Authored-By: Isaack Mwenda <[email protected]>

line space Co-Authored-By: Isaack Mwenda <[email protected]>

Update log info Co-Authored-By: Isaack Mwenda <[email protected]>

del log info Co-Authored-By: Isaack Mwenda <[email protected]>

IsaackMwenda

Thanks, @DanielMwendwa @as2388

DanielMwendwa added 3 commits February 14, 2020 22:29

script to compute number messages in a given period of time

fa41683

renamed variable

23599b7

added comments to blocks of code

c00571a

DanielMwendwa requested a review from as2388 February 15, 2020 08:05

as2388 reviewed Feb 17, 2020

View reviewed changes

DanielMwendwa requested a review from as2388 February 19, 2020 08:33

renamed comandline arguments and their reference

68b016a

as2388 requested changes Feb 19, 2020

View reviewed changes

DanielMwendwa and others added 14 commits February 19, 2020 19:04

Update mno_analysis_tools/compute_messages_per_period.py

a7eaf2d

Co-Authored-By: Alexander Simpson <[email protected]>

Merge branch 'master' into compute_msgs_per_period

d993196

renamed project name being used by Logger class

e7fff68

updated comments

21d2582

renamed a variable

c73338f

renamed 2 dictionary keys

29f5718

added log info before & after filtering messages based on operator an…

b2792cc

…d direction of msg

memory efficient way to read a file

f51df2d

updated function return type to list

0bd5544

updated help message for command line arguement

3f2cb6a

added isodate into packages

ef9b928

updated metavar attribute for the parser to standard

5d161d4

updated time-frame commandline arg to use isodate.parse_duration

235acb9

adjusted the length of 2 lines of code

a6eeb7e

DanielMwendwa requested a review from as2388 February 21, 2020 12:43

DanielMwendwa added 4 commits February 26, 2020 11:22

removed 'isodate' from dependencies

8e02037

Format as hh:mm:ss and parse into a timedelta

e3ae172

indented block of code

606dbcd

compute message differences

8cda729

as2388 requested changes Feb 26, 2020

View reviewed changes

DanielMwendwa and others added 2 commits February 26, 2020 19:09

Update mno_analysis_tools/compute_messages_per_period.py

807a580

remove extra space after comma Co-Authored-By: Alexander Simpson <[email protected]>

Update mno_analysis_tools/compute_messages_per_period.py

73054bb

renamed variable Co-Authored-By: Alexander Simpson <[email protected]>

DanielMwendwa added 3 commits February 27, 2020 14:50

updated upper argument to range

fe76b46

updated upper argument to range

bd89716

remove isodate and updated firebase-admin

6cb0c86

DanielMwendwa requested a review from as2388 February 27, 2020 12:03

as2388 approved these changes Feb 27, 2020

View reviewed changes

DanielMwendwa and others added 5 commits February 27, 2020 22:52

Update mno_analysis_tools/compute_messages_per_period.py

af5ebd2

remove comma from string Co-Authored-By: Alexander Simpson <[email protected]>

resolved wrong metavar

816d658

renamed argument parser argument

b57f944

updated log info

d7980eb

removed computation of absolute value of subtracted values

ffe0160

DanielMwendwa requested a review from IsaackMwenda February 28, 2020 13:32

DanielMwendwa added 3 commits February 28, 2020 16:44

used operator and msg.direction on creating dict, so we can optionall…

ae8b739

…y validate later

added on operator and msg diff when computing msg difference

2291bfb

moved statement into condition statement

6fe5d15

IsaackMwenda requested changes Mar 2, 2020

View reviewed changes

DanielMwendwa and others added 10 commits March 2, 2020 14:48

Update mno_analysis_tools/compute_messages_per_period.py

0780b67

Rename parser help message Co-Authored-By: Isaack Mwenda <[email protected]>

Update mno_analysis_tools/compute_messages_per_period.py

205b161

Updated log information Co-Authored-By: Isaack Mwenda <[email protected]>

Update mno_analysis_tools/compute_messages_per_period.py

e5e59ba

Updated log information Co-Authored-By: Isaack Mwenda <[email protected]>

Update mno_analysis_tools/compute_messages_per_period.py

82ab469

line space Co-Authored-By: Isaack Mwenda <[email protected]>

Update mno_analysis_tools/compute_messages_per_period.py

740caf7

Update log info Co-Authored-By: Isaack Mwenda <[email protected]>

Update mno_analysis_tools/compute_messages_per_period.py

6f65dbb

Update log info Co-Authored-By: Isaack Mwenda <[email protected]>

Update mno_analysis_tools/compute_messages_per_period.py

b17e0df

del log info Co-Authored-By: Isaack Mwenda <[email protected]>

remove log info

76a5f20

updated log info

f3dd968

added days to timeframe arg

6005642

DanielMwendwa requested a review from IsaackMwenda March 2, 2020 12:31

IsaackMwenda approved these changes Mar 4, 2020

View reviewed changes

DanielMwendwa merged commit 197dc30 into master Mar 4, 2020

DanielMwendwa mentioned this pull request Mar 5, 2020

format argparse arguments #77

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

script to compute number messages in a given period of time #67

script to compute number messages in a given period of time #67

DanielMwendwa commented Feb 14, 2020

as2388 left a comment

as2388 left a comment

DanielMwendwa commented Feb 28, 2020

IsaackMwenda Mar 2, 2020

IsaackMwenda left a comment

script to compute number messages in a given period of time #67

script to compute number messages in a given period of time #67

Conversation

DanielMwendwa commented Feb 14, 2020

as2388 left a comment

Choose a reason for hiding this comment

as2388 left a comment

Choose a reason for hiding this comment

DanielMwendwa commented Feb 28, 2020

IsaackMwenda Mar 2, 2020

Choose a reason for hiding this comment

IsaackMwenda left a comment

Choose a reason for hiding this comment