Add 'ignore_archives' flag to functions that fetch runs #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults to False, so default behaviour is to always fetch from archives.
The intention here is that pipelines can set ignore_archives to True when incrementally fetching new data for a dataset they fetched in the past. This is a cheap and simple way to work around the performance problem of pipelines going to archives if the last message received was more than 3 months ago. Of course, this would cause us problems if more than 3 months pass between a pipeline run and we're fetching a flow that had some data in archives 3 months ago, but this is extremely unlikely to happen in practice. This is because we run pipelines frequently then terminate flows forever, and in any case can workaround by removing the Raw Data folder.
(In other words, this prevents the incremental fetching performance problem originally described here: #60).
For example usage, see AfricasVoices/Project-IOM#19