Add functions for listing and downloading archives #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukechurch
approved these changes
Jan 10, 2020
| # I haven't verified this). Since this field is often null in the data that comes out of the runs | ||
| # API directly, and we don't use this in the pipelines, just set missing entries to None. | ||
| if "start" not in serialized_run: | ||
| serialized_run["start"] = None |
There was a problem hiding this comment.
This seems odd as a thing to need to do - is it work logging a warning?
There was a problem hiding this comment.
I'm not sure what that tells us - I don't know what this field is for, and it's almost always null in the objects read from the runs API too
IsaackMwenda
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.