add function to get rapidpro groups #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as2388
approved these changes
Jan 19, 2022
rapid_pro_tools/rapid_pro_client.py
Outdated
Comment on lines
303
to
306
| :param before: modified before | ||
| :type before: datetime | ||
| :param after: modified after | ||
| :type before: datetime |
There was a problem hiding this comment.
Elsewhere in this file we called this last_modified_before_exclusive and last_modified_after_inclusive. I suggest doing the same here so it's super unambiguous what the filter means without needing to check the api docs
There was a problem hiding this comment.
Updated thanks.
| :rtype: temba_client.v2.types.Group | ||
| """ | ||
|
|
||
| return self._retry_on_rate_exceed(lambda: self.rapid_pro.create_group(name=name)) |
There was a problem hiding this comment.
Does this fail if the group already exists?
There was a problem hiding this comment.
If the group exists, rapid pro will add a suffix 1,2.. and create a group with the modified name. Have updated the docstrings to highlight this thanks.
DanielMwendwa
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new functions to support automated advert sync to rapid_pro.