Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional field_id argument to create_field #114

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

as2388
Copy link
Member

@as2388 as2388 commented Oct 7, 2020

No description provided.

@as2388 as2388 requested a review from IsaackMwenda October 7, 2020 15:35
Copy link
Contributor

@IsaackMwenda IsaackMwenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. May I check how you have tested this?

@as2388
Copy link
Member Author

as2388 commented Oct 9, 2020

LGTM. May I check how you have tested this?

Yes, thanks for checking: I called this function manually against one of our test workspaces, using the field id and string parameters from the problematic cases we encountered when migrating COVID, and tested that:

  • The strategy of asking for a label that looks like the field id then updating works.
  • Providing an invalid field id causes the script to fail.
  • Attempting to create an existing field fails.
    I think that's as much as I can do in test, we can see how it goes when we sync CSAP.

@as2388 as2388 merged commit a513722 into master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants