Use default warning type for the get_raw_runs_for_flow_id deprecation #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… warning instead of DeprecationWarning DeprecationWarnings don't show by default in 3.6, and I think it's more effort than it's worth to set a filter on all the projects. Worse, the filter defaults change across minor versions of Python, and matplotlib (and possibly other libraries) bypasses the built-in filters anyway by creating its own MatplotlibDeprecationWarning.
IsaackMwenda
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review #111 first.
DeprecationWarnings don't show by default in 3.6, and I think it's more effort than it's worth to set a filter on all the projects. Worse, the filter defaults change across minor versions of Python, and matplotlib (and possibly other libraries) bypasses the built-in filters anyway by creating its own MatplotlibDeprecationWarning, so I think this is the simplest "solution"