Move max segment size to an argument #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review #224, #223 first.
Replaces firebase_client_wrapper.MAX_SEGMENT_SIZE with a --max-segment-size argument in the relevant tools.
We need this in order to be able to dynamically configure the max segment size for each dataset, because we chose to only segment datasets "when they become a problem", meaning we have some non-segmented datasets which are larger than the segment size of those which are segmented.
An outstanding unresolved issue was whether we should check if the passed max-segment-size is the same as the one that was used previously for a given dataset. This is not addressed here, but could be in a future PR if we think we need it and agree on a design.
It's also worth saying that this update will mean that restore.py allows us to set a different segment size to what was backed up. This is probably not desirable, so we may need to update backup.py and restore.py to understand segments. Something else for another PR?