Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: GST sentence #124

Merged
merged 6 commits into from
May 5, 2024
Merged

Feat: GST sentence #124

merged 6 commits into from
May 5, 2024

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented May 5, 2024

Based on #121 to fix a merge conflict.
Thank you @zhrbrk for working on this sentence, sorry it took me some time to review your PR I got to a point and then left the PR review unfinished.

Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 78.11%. Comparing base (6bfcd5a) to head (879b3f4).

Files Patch % Lines
src/sentences/gst.rs 87.50% 3 Missing ⚠️
src/parser.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   77.96%   78.11%   +0.14%     
==========================================
  Files          35       36       +1     
  Lines        1307     1334      +27     
==========================================
+ Hits         1019     1042      +23     
- Misses        288      292       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elpiel elpiel merged commit db629f6 into main May 5, 2024
15 checks passed
@elpiel elpiel deleted the feat/gst-sentence branch May 5, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants