-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mb way international phone number #1601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spritesheet mapping
…ops to be 'phoneNumber' & 'phonePrefix'
…rom some selectors
sponglord
requested review from
marcperez,
pabloai,
shernaz,
m1aw and
ribeiroguilherme
as code owners
May 13, 2022 15:13
Size Change: +4.86 kB (+1%) Total Size: 774 kB
ℹ️ View Unchanged
|
ribeiroguilherme
approved these changes
May 20, 2022
packages/lib/src/components/internal/SecuredFields/lib/utilities/commonUtils.ts
Outdated
Show resolved
Hide resolved
packages/lib/src/components/MBWay/components/MBWayInput/MBWayInput.tsx
Outdated
Show resolved
Hide resolved
packages/lib/src/components/MBWay/components/MBWayInput/MBWayInput.tsx
Outdated
Show resolved
Hide resolved
Merged
ribeiroguilherme
approved these changes
May 23, 2022
packages/lib/src/components/MBWay/components/MBWayInput/MBWayInput.tsx
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding an international phone prefix dropdown to the current phone number field to allow international phone numbers in the MBWay component.
Previously this component just had a single input into which the user was expected to type a Portuguese mobile phone number (either with or without the international "+351" prefix).
Now the component consists of 2 parts:
Tested scenarios
All existing unit and e2e tests pass
Fixed issue: COWEB-835
Also resolves this issue for the magento plugin