Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mb way international phone number #1601

Merged
merged 22 commits into from
May 23, 2022

Conversation

sponglord
Copy link
Contributor

@sponglord sponglord commented May 13, 2022

Summary

Adding an international phone prefix dropdown to the current phone number field to allow international phone numbers in the MBWay component.

Previously this component just had a single input into which the user was expected to type a Portuguese mobile phone number (either with or without the international "+351" prefix).

Now the component consists of 2 parts:

  • an international country code selector (shows flags + international phone prefix + 2 character country code)
  • an input into which to type the domestic part of the phone number

Tested scenarios

All existing unit and e2e tests pass

Fixed issue: COWEB-835
Also resolves this issue for the magento plugin

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2022

Size Change: +4.86 kB (+1%)

Total Size: 774 kB

Filename Size Change
packages/lib/dist/adyen.js 208 kB +1.26 kB (+1%)
packages/lib/dist/cjs/index.js 176 kB +1.25 kB (+1%)
packages/lib/dist/es.modern/index.js 92.1 kB +1.08 kB (+1%)
packages/lib/dist/es/index.js 107 kB +1.26 kB (+1%)
ℹ️ View Unchanged
Filename Size
packages/lib/dist/es.modern/ar.js 4.48 kB
packages/lib/dist/es.modern/cs-CZ.js 4.01 kB
packages/lib/dist/es.modern/da-DK.js 3.64 kB
packages/lib/dist/es.modern/de-DE.js 3.93 kB
packages/lib/dist/es.modern/el-GR.js 4.95 kB
packages/lib/dist/es.modern/es-ES.js 3.67 kB
packages/lib/dist/es.modern/fi-FI.js 3.72 kB
packages/lib/dist/es.modern/fr-FR.js 3.87 kB
packages/lib/dist/es.modern/hr-HR.js 3.79 kB
packages/lib/dist/es.modern/hu-HU.js 3.97 kB
packages/lib/dist/es.modern/it-IT.js 3.67 kB
packages/lib/dist/es.modern/ja-JP.js 4.43 kB
packages/lib/dist/es.modern/ko-KR.js 4.04 kB
packages/lib/dist/es.modern/nl-NL.js 3.7 kB
packages/lib/dist/es.modern/no-NO.js 3.63 kB
packages/lib/dist/es.modern/pl-PL.js 4.05 kB
packages/lib/dist/es.modern/pt-BR.js 3.71 kB
packages/lib/dist/es.modern/ro-RO.js 3.92 kB
packages/lib/dist/es.modern/ru-RU.js 4.67 kB
packages/lib/dist/es.modern/sk-SK.js 4.05 kB
packages/lib/dist/es.modern/sl-SI.js 3.7 kB
packages/lib/dist/es.modern/sv-SE.js 3.67 kB
packages/lib/dist/es.modern/zh-CN.js 3.94 kB
packages/lib/dist/es.modern/zh-TW.js 4.1 kB
packages/lib/dist/es/ar.js 4.48 kB
packages/lib/dist/es/cs-CZ.js 4.01 kB
packages/lib/dist/es/da-DK.js 3.64 kB
packages/lib/dist/es/de-DE.js 3.93 kB
packages/lib/dist/es/el-GR.js 4.95 kB
packages/lib/dist/es/es-ES.js 3.67 kB
packages/lib/dist/es/fi-FI.js 3.72 kB
packages/lib/dist/es/fr-FR.js 3.87 kB
packages/lib/dist/es/hr-HR.js 3.79 kB
packages/lib/dist/es/hu-HU.js 3.97 kB
packages/lib/dist/es/it-IT.js 3.67 kB
packages/lib/dist/es/ja-JP.js 4.43 kB
packages/lib/dist/es/ko-KR.js 4.04 kB
packages/lib/dist/es/nl-NL.js 3.7 kB
packages/lib/dist/es/no-NO.js 3.63 kB
packages/lib/dist/es/pl-PL.js 4.05 kB
packages/lib/dist/es/pt-BR.js 3.71 kB
packages/lib/dist/es/ro-RO.js 3.92 kB
packages/lib/dist/es/ru-RU.js 4.67 kB
packages/lib/dist/es/sk-SK.js 4.05 kB
packages/lib/dist/es/sl-SI.js 3.7 kB
packages/lib/dist/es/sv-SE.js 3.67 kB
packages/lib/dist/es/zh-CN.js 3.94 kB
packages/lib/dist/es/zh-TW.js 4.1 kB

compressed-size-action

@ribeiroguilherme ribeiroguilherme mentioned this pull request May 23, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sponglord sponglord merged commit f3f9c1d into master May 23, 2022
@sponglord sponglord deleted the feature/MBWay_international_phone_number branch May 23, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants