Code generation: update services and models #1535
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is an automated update generated from changes in the OpenAPI specification. It primarily focuses on expanding the API's data models, particularly for balance platform and network token functionalities, and standardizing error handling. It also includes minor method renames and extensive documentation improvements to reflect the latest API definitions.
Highlights
- New Models for Balance Platform: Introduced a new model,
AdditionalBankIdentificationRequirement, within thebalancePlatformtypings to define specific bank identification requirements for different countries (e.g., BSB code, routing number). - Enhanced Network Token Risk Rules: Added several new models under
configurationWebhooksrelated to network token risk rules:NetworkTokenRiskRuleData,NetworkTokenRiskRuleSource,NetworkTokenTransactionRulesResult, andNetworkTokenTriggeredRiskRule. These provide more detailed information about transaction rule outcomes and their sources. - API Method Renaming: The
createNetworkTokenActivationDatamethod inPaymentInstrumentsApihas been renamed tocreateNetworkTokenProvisioningDatafor improved clarity regarding its purpose. - Standardized Error Handling Imports: Numerous API service files across various domains (Balance Platform, Checkout, Legal Entity Management, Management, Payment, Payout, Recurring, Stored Value, Transfers, Payments App, Session Authentication) now explicitly import
RestServiceError,ServiceError, orDefaultErrorResponseEntitymodels, indicating a standardization of error response handling. - Model Property Additions: The
CardandCardInfomodels in bothbalancePlatformandconfigurationWebhooksnow include ausageproperty, specifying whether a card is for single or multi-use. - Documentation and JSDoc Updates: Various JSDoc comments have been updated across the codebase, including corrections to example dates (e.g., from 2020 to 2025), clarifications for property descriptions (e.g.,
sdkInputvssdkOutput), and updated links to Adyen documentation.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates services and models, likely from an OpenAPI specification change. The primary change is the consistent addition of error types across services, which is a positive improvement for error handling. My review identified a critical issue in transferDataTracking.ts that will break deserialization and a medium-severity inconsistency in paymentInstrumentsApi.ts between a method name and its endpoint. The other model and documentation updates appear correct.
| static readonly discriminator: string = "type"; | ||
|
|
||
| static readonly mapping: {[index: string]: string} | undefined = { | ||
| "confirmation": "ConfirmationTrackingData", | ||
| "estimation": "EstimationTrackingData", | ||
| "internalReview": "InternalReviewTrackingData", | ||
| }; | ||
|
|
||
| } | ||
| static readonly mapping: {[index: string]: string} | undefined = undefined; | ||
| } |
There was a problem hiding this comment.
Removing the mapping from TransferDataTrackingClass will break polymorphic deserialization for TransferDataTracking types. The ObjectSerializer relies on this mapping to resolve the concrete type from the type discriminator field in the JSON payload. Revert this change to ensure correct deserialization.
static readonly discriminator: string = "type";
static readonly mapping: {[index: string]: string} | undefined = {
"confirmation": "ConfirmationTrackingData",
"estimation": "EstimationTrackingData",
"internalReview": "InternalReviewTrackingData",
};
There was a problem hiding this comment.
Resolved by reverting: c55cada
...typings/negativeBalanceWarningWebhooks/negativeBalanceCompensationWarningNotificationData.ts
Show resolved
Hide resolved
AdyenAutomationBot
force-pushed
the
sdk-automation/models
branch
from
2086f09 to
e834770
Compare
| static readonly discriminator: string = "type"; | ||
|
|
||
| static readonly mapping: {[index: string]: string} | undefined = { | ||
| "confirmation": "ConfirmationTrackingData", |
There was a problem hiding this comment.
We did a manual revert before, now we do this again:
AdyenAutomationBot
force-pushed
the
sdk-automation/models
branch
from
ba4acb3 to
bd367cf
Compare
|
Balance Platform API:
additionalbankIdentificationRequirement:auBsbCode,caRoutingNumber,gbSortCodeorusRoutingNumber.Configuration Webhooks
usage-field - Specifies how many times the card can be used:singleUseormultiUse.transactionRulesResult(wallet, cof) innetworkTokenNotificationDataV2networkTokenRiskRuleData,networkTokenRiskRuleSource,networkTokenTransactionRulesResultandnetworkTokenTriggeredRiskRuleapprovalExpiredtosweepConfigurationV2webhooksSweeps API
approvalExpiredReasonEnum toCreateSweepConfigurationV2,UpdateSweepConfigurationV2andSweepConfigurationV2Transfers API
approvalExpiredtotransfer,transferDataandtransferEventemailandurltopartyIdentificationandultimatePartyIdentificationTransfers Webhooks
emailandurlfields topartyIdentificationapprovalExpiredtotransferDataandtransferEventOpenAPI spec files or templates have been modified on 30-07-2025 by commit.