Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding src/de/2025-01/04/teacher-questions.md and previous #3155

Closed
wants to merge 58 commits into from
Closed

Adding src/de/2025-01/04/teacher-questions.md and previous #3155

wants to merge 58 commits into from

Conversation

toak
Copy link
Contributor

@toak toak commented Oct 18, 2024

for adult lesson de/2024-04
from wiki.sabbatschule.at

Pull Request check-list

Please make sure to review and check all of these items:

  • Have you checked for semicolons in the titles?

VitalikL
VitalikL requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@VitalikL VitalikL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toak Unfortunately we can no longer accept improperly formatted files, please clean it up from using non-markdown format. The changes requested look like they are auto-generated

src/de/2024-04/03/teacher-questions.md Outdated
@@ -9,6 +9,9 @@ date: 18/10/2024

- Was in diesem Abschnitt könnt ihr logisch nicht nachvollziehen?

```{=html}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toak Unfortunately we can no longer accept improperly formatted files, please clean it up from using non-markdown format.

src/de/2024-04/03/teacher-questions.md Outdated
*The message of John: here is your king!: with study guide*, The Bible
Speaks Today (Leicester, England; Downers Grove, IL: InterVarsity Press,
1993), 4

Weitere Fragen oder Ideen? - du bist herzlich zur Mitarbeit eingeladen: https://wiki.sabbatschule.at
Weitere Fragen oder Ideen? - du bist herzlich zur Mitarbeit eingeladen:
<https://wiki.sabbatschule.at>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links should also be properly formatted

@VitalikL
Copy link
Member

@toak I spent some time to clean up almost all previous teacher-questions - you can take a look, but even then the changes I made are not ideal. Ideally we would like clean Markdown format, because we are preparing big upgrade to our API and the app to avoid HTML completely.

@toak
Copy link
Contributor Author

toak commented Oct 18, 2024

Thanks for the heads-up, I'll update the routine to remove HTML

@toak
Copy link
Contributor Author

toak commented Oct 18, 2024

The source of the content is wiki.sabbatschule.at
I have changed the converter now to be markdown_strict without HTML: (new commits)
pandoc -f mediawiki -t markdown_strict-raw_html

Let me know what else you want to have improved @VitalikL

@toak toak requested a review from VitalikL October 18, 2024 16:27
VitalikL
VitalikL requested changes Oct 20, 2024
View reviewed changes
@toak
Copy link
Contributor Author

toak commented Oct 21, 2024

@VitalikL I'll fix the issues with the converter in the next days

@toak
Copy link
Contributor Author

toak commented Nov 1, 2024

@VitalikL I've added some additional rules to the conversation process, so the current files should be clean. If you notice some other issues, please comment on the PR, so I can fix the converter.

@toak toak requested a review from VitalikL November 2, 2024 22:01
@toak
Copy link
Contributor Author

toak commented Nov 2, 2024

@VitalikL everything should now be ready for the pull

toak added 9 commits November 2, 2024 22:13
@toak
Adding src/de/2025-01/07/teacher-questions.md and previous
b3ebe97
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
583afda 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
86dd9e4 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
b9d2601 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
d02b7f8 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
a29606e 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
2c97f5e 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
afd5585 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
8062310 
…essons into stage
toak added 20 commits November 22, 2024 00:00
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
6c387e7 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
ef2cab0 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
c91aed8 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
3b6e52e 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
e20b11a 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
425a3b6 
…essons into stage
@toak
Adding src/de/2025-01/10/teacher-questions.md and previous
f377ade
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
2ee077c 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
1052757 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
fb48d76 
…essons into stage
@toak
Adding src/de/2025-01/10/teacher-questions.md and previous
e283ae3
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
05adcb7 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
56f0ed2 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
883d690 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
3c87672 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
a44f8b7 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
c9b64c6 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
d030810 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
0bc1cea 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
b3f6c8e 
…essons into stage
@toak
Copy link
Contributor Author

toak commented Dec 9, 2024

@VitalikL do you want me to change anything before you can merge? I regularly keep things up to date to avoid merge requests
I already got the questions from users when the questions will be available.

toak added 8 commits December 10, 2024 00:00
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
706894c 
…essons into stage
@toak
Adding src/de/2025-01/12/teacher-questions.md and previous
e2bbdb0
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
93b1711 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
fb969fe 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
d653229 
…essons into stage
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
eeee7ee 
…essons into stage
@toak
Adding src/de/2025-01/12/teacher-questions.md and previous
03965d7
@toak
Merge branch 'stage' of https://github.com/Adventech/sabbath-school-l…
e270c41 
…essons into stage
@toak toak closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitalikL VitalikL Awaiting requested review from VitalikL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toak @VitalikL