Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original PDF view shows the tabbar as transparent #133

Conversation

EmersonCarpes
Copy link
Contributor

@EmersonCarpes EmersonCarpes commented Feb 5, 2023

  • Implemented TabBarLessViewController protocol to hide tabbar when view conform with this protocol
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-02-05.at.16.04.51.mp4

@VitalikL
Copy link
Member

VitalikL commented Feb 7, 2023

@EmersonCarpes Is it easy to show the tabbar always but not transparent for the PDF view?

@EmersonCarpes
Copy link
Contributor Author

yes, I just thought as we are on "reader mode" would make sense focus on content, but, I will work on that @VitalikL

@EmersonCarpes
Copy link
Contributor Author

Fixed @VitalikL , I kept TabBarLessViewController just in case we need to hide tab bar in some screen.

@VitalikL VitalikL deleted the branch feature/adding-tabbar December 25, 2024 17:09
@VitalikL VitalikL closed this Dec 25, 2024
@VitalikL VitalikL deleted the feature/originalPDFViewsShowsTabbarTransparent branch December 25, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants