Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive alien removal (and a few bug fixes) #32

Open
wants to merge 7 commits into
base: Dev
Choose a base branch
from

Conversation

jacione
Copy link
Contributor

@jacione jacione commented Oct 2, 2024

  1. I actually synced my fork before doing this, and there were a few small bugs in the multipeak stuff. I fixed those, so it should run smoothly now.
  2. I created an algorithm that uses the redundancy of multipeak datasets to detect and remove aliens, as well as lend extra support to datasets with bad SNR. It works really well, and I think it's a huge step toward being able to reconstruct data immediately without visual inspection.
  3. I added/removed/changed some parameters in config_mp. I still need to go in and add the documentation for those (as well as some older things...)

I think there are a few more things I need to clean up before this is ready to merge, but I wanted to put it on your radar. Should be ready in a few days.

Before phasing on a new peak, it compares the shared-object projected diffraction to the actual measured diffraction (both with a 1-pixel gaussian blur). A difference map is defined as the absolute difference between the two blurred images divided by the blurred projection. A mask is generated from all the voxels where the difference map is greater than twice its own median.
While the peak is being phased, the Fourier constraint is enforced using the measurement outside the mask and the projection inside.
…aint. The amount of feedback depends on that peak's confidence value.
Removed:
- adaptive_weights (replaced by adapt_trigger)

Added:
- adapt_trigger: Puts the adaptive weighting in the operation/trigger format
- adapt_power: Basically how harshly bad peaks are punished
- adapt_alien_start: When to start removing aliens
- adapt_alien_threshold: Voxels are masked where the error map exceeds this times its median

Renamed:
- weight_X << mp_weight_X
- adapt_threshold_X << peak_threshold_X
@jacione
Copy link
Contributor Author

jacione commented Oct 3, 2024

Ready to merge. I updated all the documentation for config_mp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant