Skip to content

Fix: Correct site_url handling for custom post types and taxonomies in acf admin #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Correct site_url handling for custom post types and taxonomies in acf admin #957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion includes/admin/views/acf-post-type/advanced-settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,7 +1052,7 @@
/* translators: this string will be appended with the new permalink structure. */
'custom_permalink_instructions' => __( 'Rewrite the URL using a custom slug defined in the input below. Your permalink structure will be', 'acf' ) . ' {slug}.',
'no_permalink_instructions' => __( 'Permalinks for this post type are disabled.', 'acf' ),
'site_url' => get_site_url(),
'site_url' => get_home_url(),
),
'class' => 'permalink_rewrite',
),
Expand Down
4 changes: 2 additions & 2 deletions includes/admin/views/acf-taxonomy/advanced-settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
)
);
?>

<?php
acf_render_field_wrap(
array(
Expand Down Expand Up @@ -942,7 +942,7 @@
/* translators: this string will be appended with the new permalink structure. */
'custom_permalink_instructions' => __( 'Rewrite the URL using a custom slug defined in the input below. Your permalink structure will be', 'acf' ) . ' {slug}.',
'no_permalink_instructions' => __( 'Permalinks for this taxonomy are disabled.', 'acf' ),
'site_url' => get_site_url(),
'site_url' => get_home_url(),
),
'class' => 'permalink_rewrite',
),
Expand Down