Moving from logical end (&&) to semicolon based script#443
Merged
dinogun merged 1 commit intoAdoptOpenJDK:masterfrom Oct 15, 2020
Merged
Moving from logical end (&&) to semicolon based script#443dinogun merged 1 commit intoAdoptOpenJDK:masterfrom
dinogun merged 1 commit intoAdoptOpenJDK:masterfrom
Conversation
bharathappali
force-pushed
the
fix-and-semicolon
branch
from
1f5a28f to
9b9d3aa
Compare
dinogun
reviewed
Oct 15, 2020
bharathappali
force-pushed
the
fix-and-semicolon
branch
4 times, most recently
from
627f5c5 to
b8585db
Compare
Signed-off-by: bharathappali <bharath.appali@gmail.com>
bharathappali
force-pushed
the
fix-and-semicolon
branch
from
b8585db to
7eef93d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR comment in docker official images state the use of semicolon based script rather than a script with logical and (&&)
REF: docker-library/official-images#8781 (comment)
This PR makes the script to have semicolon.
@dinogun Can i know your views on this ? Thanks in advance.
Signed-off-by: bharathappali bharath.appali@gmail.com