Add SCC generation code to the dockerfile and remove the external script#438
Merged
dinogun merged 1 commit intoAdoptOpenJDK:masterfrom Oct 13, 2020
Merged
Conversation
dinogun
requested changes
Oct 13, 2020
dinogun
reviewed
Oct 13, 2020
bharathappali
force-pushed
the
print-scc-gen-dockerfile
branch
from
5fe65ad to
bb1f080
Compare
…n in dockerfile itself Signed-off-by: bharathappali <bharath.appali@gmail.com>
bharathappali
force-pushed
the
print-scc-gen-dockerfile
branch
from
bb1f080 to
4fd93c1
Compare
dinogun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on reviews at docker official images moving the scc generation part from script to the dockerfile itself.
@karianna @dinogun Can i have your views on this ? Thanks in advance.
Signed-off-by: bharathappali bharath.appali@gmail.com