Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.md #671

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update index.md #671

wants to merge 5 commits into from

Conversation

Alicesnk
Copy link

updating the CAMPAIGN version

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

rymorale
rymorale reviewed Aug 28, 2024
View reviewed changes
src/pages/resources/reference/push-notifications/templates/index.md Outdated
@@ -14,17 +14,17 @@ This document outlines the push templates that are supported by default.

<InlineAlert variant="info" slots="text"/>

Default push template functionality is available for use with the **Adobe Campaign Classic** extension.
Default push template functionality is available for use with the **Adobe Campaign Classic** extension. In additon, the rich push template functionality is supported starting Campaign v8.
Copy link
Contributor

@rymorale rymorale Aug 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "... is supported starting with Campaign v8." is easier to read. In addition, should we say Campaign Classic v8 instead of Campaign v8? IMO, our docs here cover the Campaign Standard extension as well and this may lead to some confusion. This applies to the naming changes below as well.

Copy link
Contributor

@calebk1 calebk1 Aug 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with saying "... starting with Campaign v8."

Also, there's an extra space after the period.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @rymorale and @calebk1 for your feedback. I updated as you suggested. Campaign Classic is only for v7. Starting v8, we should only refer to Adobe Campaign.

calebk1
calebk1 requested changes Aug 28, 2024
View reviewed changes
src/pages/resources/reference/push-notifications/templates/index.md Outdated
@@ -14,17 +14,17 @@ This document outlines the push templates that are supported by default.

<InlineAlert variant="info" slots="text"/>

Default push template functionality is available for use with the **Adobe Campaign Classic** extension.
Default push template functionality is available for use with the **Adobe Campaign Classic** extension. In additon, the rich push template functionality is supported starting Campaign v8.
Copy link
Contributor

@calebk1 calebk1 Aug 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with saying "... starting with Campaign v8."

Also, there's an extra space after the period.

@rymorale
Copy link
Contributor

we had a discussion about the name change in our docs during our squad meeting today. i think we need to keep the campaign classic name the same within the aepsdk docs hosted here. we won't be updating the name of our aepsdk campaign classic extension and it could lead to confusion for our customers as we also have a aepsdk campaign standard extension.

rymorale
rymorale requested changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@rymorale rymorale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment regarding removing the name change of classic to v8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebk1 calebk1 calebk1 requested changes

@rymorale rymorale rymorale requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alicesnk @rymorale @calebk1