[aws-json] Migrate SNS ListTopics #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kojisaikiAtSony
force-pushed
the
add_sns_listtopics_support
branch
from
8cbd809
to
03e4e02
Compare
|
Ready to merge! |
kojisaikiAtSony
force-pushed
the
add_sns_listtopics_support
branch
2 times, most recently
from
bb4a35e
to
a91f51b
Compare
minor fixes add not implemented comment to sns model reset tests affecting new tests add debug message when listing sns topics remove merge remnants, minor fixups update listtopics test to handle new mock config
|
Looks like something is up with the unit tests on these now? If we can get that sorted I think they look good to go! |
kojisaikiAtSony
force-pushed
the
add_sns_listtopics_support
branch
from
a91f51b
to
71373a6
Compare
|
@Admiral-Piett Sorry, fixed the test on ListTopics/DeleteTopic! |
Admiral-Piett
merged commit 19dd37a
into
Admiral-Piett:feature-aws-json
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.