[aws-json] Migrate SQS DeleteMessageBatch #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kojisaikiAtSony
changed the title
|
I think this one needs a commit squash too btw. |
Yes, we are working on your comments, please wait a moment 👍 |
kojisaikiAtSony
force-pushed
the
feature-aws-json-delete-message-batch
branch
from
8a9a48d
to
3756721
Compare
|
Awesome work to you and your team! Really appreciate it as always! Let's do this one next if that's ok, and then we can rebase others and get them in too? I'm closing in on Publish and I see you guys took the rest, so we're about there. Heroic effort on this project - happy to see the light at the end of the tunnel! |
added ut fix review ref review ref resolve conflicts rm sqs_messages.go
kojisaikiAtSony
force-pushed
the
feature-aws-json-delete-message-batch
branch
from
3756721
to
2a6a197
Compare
Admiral-Piett
approved these changes
Jul 16, 2024
Admiral-Piett
merged commit 89b7e55
into
Admiral-Piett:feature-aws-json
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.