Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SetQueueAttributesV1 for JSON support #302

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

Admiral-Piett
Copy link
Owner

No description provided.

@Admiral-Piett Admiral-Piett changed the base branch from master to feature-aws-json May 17, 2024 21:51
@Admiral-Piett Admiral-Piett changed the title Set queue attributes Add SetQueueAttributesV1 for JSON support May 23, 2024
@Admiral-Piett
Copy link
Owner Author

@andrew-womeldorf I rebased and now I'm getting some race condition-y/index out of bound errors in my tests. How did you fix your issues in particular? I couldn't see much from the github history with all the squashing and things.

@andrew-womeldorf
Copy link
Contributor

Interesting. The tests still pass fine on feature-aws-json, but I can reproduce the error locally when I checkout this branch. Looking...

@andrew-womeldorf
Copy link
Contributor

It looks like something maybe isn't being reset between tests. Running only the failing test, there isn't a failure

go test -cover -race -run TestReceiveMessageWaitTimeEnforcedV1 ./app/gosqs/...

@andrew-womeldorf
Copy link
Contributor

andrew-womeldorf commented May 28, 2024

Something is happening, though. If I comment out the failing test entirely, then the next test in that file fails with a similar cause.

Note the log messages prior to the failure:

time="2024-05-28T07:28:54-05:00" level=error msg="Invalid Request - ListQueuesV1"
time="2024-05-28T07:28:54-05:00" level=error msg="Invalid RedrivePolicy Attribute"
time="2024-05-28T07:28:54-05:00" level=error msg="Invalid Request - ReceiveMessageV1"
time="2024-05-28T07:28:54-05:00" level=error msg="Invalid Request - CreateQueueV1"
time="2024-05-28T07:28:54-05:00" level=error msg="Invalid Request - ReceiveMessageV1"

@andrew-womeldorf
Copy link
Contributor

If I reset the utils.REQUEST_TRANSFORMER = utils.TransformRequest at the top of the test, everything passes like normal. I'm assuming some test isn't resetting that properly. Looking...

@Admiral-Piett Admiral-Piett merged commit dcf9236 into feature-aws-json Jun 3, 2024
2 checks passed
@Admiral-Piett Admiral-Piett deleted the set-queue-attributes branch June 3, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants