Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): build multi-arch docker image with same suffix #296

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

macabu
Copy link
Contributor

@macabu macabu commented Apr 4, 2024

While trying to migrate workloads from amd64 to arm64, having a single tag for both architectures makes the transition easier.

References:

While trying to migrate workloads from amd64 to arm64, having a single tag
for both architectures makes the transition easier.

Reference: https://goreleaser.com/cookbooks/multi-platform-docker-images/#creating-multi-platform-docker-images-with-goreleaser
@Admiral-Piett
Copy link
Owner

@macabu I don't understand what we're trying to accomplish here. What tags do you want that you don't currently get?

@macabu
Copy link
Contributor Author

macabu commented Apr 11, 2024

Hi @Admiral-Piett sorry, I can clarify.

My host is arm64, and currently if I do:

~ docker pull admiralpiett/goaws
~ docker image inspect admiralpiett/goaws
...
        },
        "Architecture": "amd64",
        "Os": "linux",
        "Size": 13373043,
...

The architecture of the image is amd64. In order to pull the arm64 image, I should add a -arm64 suffix to the tag.

The idea with the PR is to provide multi-platform images, so a single tag can contain both amd64 and arm64 architectures, so that if I do:

~ docker pull admiralpiett/goaws

It auto-detects my host architecture (and pulls the arm64 image variant), unless I explicitly specify it with the --platform flag.

@Admiral-Piett
Copy link
Owner

@macabu interesting - I honestly didn't know you could do that. Let's give it a whirl! Thanks!

@Admiral-Piett Admiral-Piett merged commit 615ad59 into Admiral-Piett:master Apr 24, 2024
2 checks passed
@macabu
Copy link
Contributor Author

macabu commented Apr 25, 2024

Thank you! Pulling the images I am getting the expected result 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants